Page MenuHomePhabricator
Feed Advanced Search

Mar 12 2015

epriestley added a subtask for T7149: Allow users to import data into a new Phacility instance: T5843: Make storage backends extensible.
Mar 12 2015, 7:29 PM · Phacility
epriestley added a parent task for T5843: Make storage backends extensible: T7149: Allow users to import data into a new Phacility instance.
Mar 12 2015, 7:29 PM · Database
epriestley added a revision to T7149: Allow users to import data into a new Phacility instance: Unknown Object (Differential Revision).
Mar 12 2015, 7:09 PM · Phacility
epriestley added a comment to T7538: Consider refinements to Conpherence send-on-enter interaction.

At least on the iPhone, it's actually possible to "shift + return". Not sure if we can pick that up in JS, but might be good enough if we can.

Mar 12 2015, 7:03 PM · Conpherence (v4)
epriestley added a comment to T7538: Consider refinements to Conpherence send-on-enter interaction.

That probably means there's no way to write newlines on mobile, but oh well?

Mar 12 2015, 6:30 PM · Conpherence (v4)
epriestley added a comment to T7538: Consider refinements to Conpherence send-on-enter interaction.
  • Enter with no modifier keys sends messages.
    • Enter with any modifier key adds a newline.
    • We could remove the "Send" buttons, too, I suppose.
Mar 12 2015, 6:29 PM · Conpherence (v4)
epriestley added a comment to T7538: Consider refinements to Conpherence send-on-enter interaction.

Let's try just doing send-on-enter always? I hate preferences a whole lot (even more than send-on-enter), and we're pulling the product in a pretty chat-ey direction. If it's terrible we can add a preference.

Mar 12 2015, 6:28 PM · Conpherence (v4)
epriestley renamed Welcome from Org Chart to Welcome.
Mar 12 2015, 6:07 PM
epriestley merged task T7530: Creating a task from Quick Create menu leads to 'undefined' page into T7061: Some UIs activate dialogs incorrectly when Quicksand is active.
Mar 12 2015, 1:06 AM · Quicksand, Maniphest
epriestley updated subscribers of T7061: Some UIs activate dialogs incorrectly when Quicksand is active.
Mar 12 2015, 1:06 AM · Quicksand
epriestley added a comment to T7530: Creating a task from Quick Create menu leads to 'undefined' page.

I fixed T7514.

Mar 12 2015, 1:05 AM · Quicksand, Maniphest

Mar 11 2015

epriestley added a comment to T7531: Polish for Conpherence Durable Column.

Nice, thanks!

Mar 11 2015, 11:45 PM · Design, Conpherence
epriestley added a comment to T7531: Polish for Conpherence Durable Column.

I've had a bunch of stuff going on today, but is the "pop in" where the column loads after the page and then the whole layout jumps intentional? It feels a lot worse to me than the behavior I think we had before (empty column which loads content but doesn't reflow the whole page).

Mar 11 2015, 9:57 PM · Design, Conpherence
epriestley added a comment to T7536: Error when installing notification server.

We haven't seen this problem with npm before, so I can only offer vague advice -- are your node and npm up to date? Does installing other modules with npm work? You may have better luck filing against npm.

Mar 11 2015, 9:52 PM · Notifications
epriestley added a comment to T7524: Hovercards near screen edge should re-adjust placement.

We can cheat and do a:

Mar 11 2015, 8:06 PM · Remarkup
epriestley added a comment to T7532: Clicking "Close Window" in Durable Column doesn't set sticky preference.

This should also probably say "Hide Column" or similar, to avoid ambiguity with "Close (the browser) Window".

Mar 11 2015, 7:33 PM · Conpherence
epriestley added a parent task for T7149: Allow users to import data into a new Phacility instance: T7522: Add tooling to backpopulate instance accounts into the cluster.
Mar 11 2015, 6:42 PM · Phacility
epriestley added a subtask for T7522: Add tooling to backpopulate instance accounts into the cluster: T7149: Allow users to import data into a new Phacility instance.
Mar 11 2015, 6:42 PM · Phacility
epriestley updated subscribers of T7149: Allow users to import data into a new Phacility instance.

I've been looking at (2) a bit -- letting instances upload large files. The ideas I came up with are:

Mar 11 2015, 6:12 PM · Phacility

Mar 10 2015

epriestley added a comment to T3669: Make it easier to remember to submit inline comments when updating a diff.

Ah, nice. That feels a lot more palatable.

Mar 10 2015, 11:35 PM · Design, Differential
epriestley added a comment to T6030: Allow CustomFields to specify additional options (like "required") configurable in `<application>.fields`.

Via IRC, the account.editable option currently locks "Real Name", but it would be more flexible to make this an option on the field itself.

Mar 10 2015, 11:15 PM · Restricted Project, Restricted Project, Custom Fields
epriestley added a comment to T3669: Make it easier to remember to submit inline comments when updating a diff.

I like (3) on its own, but they all feel too heavy to actually ship to me -- (2) and (3) moreso than (1). Like, the terrible one-time clippy popup seems less bad to me than making the element that much heavier for experienced users. My thinking that we can make headway here by making the "draft" state more obvious may ultimately be misguided, since these are pretty tame but still feel too heavy to me.

Mar 10 2015, 11:03 PM · Design, Differential
epriestley added a comment to T7380: Build icon-based room switcher for persistent chat pane.

I think making the 7th icon a fixed "more" (or maybe eventually a dropdown) makes a ton of sense.

Mar 10 2015, 10:39 PM · Conpherence
epriestley closed T7060: Quicksand and Conpherence interact incorrectly as Resolved by committing Restricted Diffusion Commit.
Mar 10 2015, 10:32 PM · Quicksand
epriestley added a revision to T7060: Quicksand and Conpherence interact incorrectly: Unknown Object (Differential Revision).
Mar 10 2015, 10:13 PM · Quicksand
epriestley created T7522: Add tooling to backpopulate instance accounts into the cluster.
Mar 10 2015, 9:56 PM · Phacility
epriestley added a comment to T7520: Highlighted code doesn't stay highlighted when leaving a comment.

I did consciously think about the behavior, but it's possible I did that after accidentally changing it. However, there wasn't any code to save/restore the focused element so I'm like 95% sure the behavior didn't change.

Mar 10 2015, 2:28 AM · Differential
epriestley added a comment to T7520: Highlighted code doesn't stay highlighted when leaving a comment.

Pretty sure I didn't change that, although it's possible I did by accident.

Mar 10 2015, 2:27 AM · Differential
epriestley added a comment to T7520: Highlighted code doesn't stay highlighted when leaving a comment.

This is intended. In particular, if you highlight other inline comments we'll update the reticle to show you the code they cover, if you need a reminder. Code can also be kind of hard to read through the reticle. We could lock it while the editor is active if you haven't moused over anything, but it seems reasonable to me as-is?

Mar 10 2015, 2:22 AM · Differential
epriestley added a revision to T1460: Add "Done" link to an inline comment: Unknown Object (Differential Revision).
Mar 10 2015, 1:48 AM · User Delight, Differential
chad awarded T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity a Doubloon token.
Mar 10 2015, 12:37 AM · Differential
epriestley closed T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity as Resolved.

This probably still has some bugs, but I don't know what they are yet. The code is now relatively cohesive and meaningfully testable.

Mar 10 2015, 12:36 AM · Differential
epriestley closed T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity, a subtask of T4145: Spacing is totally wonky when viewing reviews on android browser, as Resolved.
Mar 10 2015, 12:36 AM · Differential
epriestley closed T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity, a subtask of T4401: Linking to lines in a diff, as Resolved.
Mar 10 2015, 12:36 AM · Differential
epriestley closed T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity, a subtask of T5179: Unearth Differential rendering technical debt, as Resolved.
Mar 10 2015, 12:36 AM · Differential
epriestley closed T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity, a subtask of T5654: Show more context for inline comments in Differential timeline, as Resolved.
Mar 10 2015, 12:36 AM · Inline Comments, Prioritized, Restricted Project, Differential
epriestley closed T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity, a subtask of T4452: Can't add code-review comments in differential's single-file view , as Resolved.
Mar 10 2015, 12:36 AM · Differential
epriestley closed T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity, a subtask of T1026: Request: ability to select line range for comment via touchscreen, as Resolved.
Mar 10 2015, 12:36 AM · Inline Comments, Differential
epriestley closed T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity, a subtask of T7447: Bring inline comments forward across revision updates, as Resolved.
Mar 10 2015, 12:36 AM · Prioritized, Differential
epriestley closed T4999: Inline comments say they are "Not Visible" when they are. as Resolved by committing Restricted Diffusion Commit.
Mar 10 2015, 12:28 AM · Differential
epriestley closed T4999: Inline comments say they are "Not Visible" when they are., a subtask of T7447: Bring inline comments forward across revision updates, as Resolved.
Mar 10 2015, 12:28 AM · Prioritized, Differential
epriestley closed T6464: Deleting a pending inline comment from the preview at the bottom doesn't remove it inline as Resolved by committing Restricted Diffusion Commit.
Mar 10 2015, 12:27 AM · Differential
epriestley closed T6464: Deleting a pending inline comment from the preview at the bottom doesn't remove it inline, a subtask of T7447: Bring inline comments forward across revision updates, as Resolved.
Mar 10 2015, 12:27 AM · Prioritized, Differential

Mar 9 2015

epriestley added a revision to T6464: Deleting a pending inline comment from the preview at the bottom doesn't remove it inline: Unknown Object (Differential Revision).
Mar 9 2015, 10:59 PM · Differential
epriestley added a revision to T4999: Inline comments say they are "Not Visible" when they are.: Unknown Object (Differential Revision).
Mar 9 2015, 10:59 PM · Differential
epriestley added a revision to T1460: Add "Done" link to an inline comment: Unknown Object (Differential Revision).
Mar 9 2015, 10:59 PM · User Delight, Differential
epriestley added a revision to T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity: Unknown Object (Differential Revision).
Mar 9 2015, 10:59 PM · Differential
epriestley added a revision to T1460: Add "Done" link to an inline comment: Unknown Object (Differential Revision).
Mar 9 2015, 7:52 PM · User Delight, Differential
epriestley added a revision to T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity: Unknown Object (Differential Revision).
Mar 9 2015, 7:52 PM · Differential
epriestley added a revision to T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity: Unknown Object (Differential Revision).
Mar 9 2015, 7:43 PM · Differential
epriestley added a revision to T1460: Add "Done" link to an inline comment: Unknown Object (Differential Revision).
Mar 9 2015, 7:43 PM · User Delight, Differential
epriestley added a revision to T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity: Unknown Object (Differential Revision).
Mar 9 2015, 7:18 PM · Differential
epriestley added a revision to T1460: Add "Done" link to an inline comment: Unknown Object (Differential Revision).
Mar 9 2015, 7:18 PM · User Delight, Differential
epriestley added a revision to T1460: Add "Done" link to an inline comment: Unknown Object (Differential Revision).
Mar 9 2015, 6:56 PM · User Delight, Differential
epriestley moved T3504: Detect file renames in incremental diff display from v2 (UI/Mobile) to Far Future Work on the Differential board.
Mar 9 2015, 5:35 PM · Restricted Project, Differential
epriestley closed T6695: Differential view for adding an empty file looks wrong as Resolved by committing Restricted Diffusion Commit.
Mar 9 2015, 5:28 PM · Differential
epriestley closed T7446: When a revision requires a CLA, hide the text of the diff as Resolved by committing Restricted Diffusion Commit.
Mar 9 2015, 5:28 PM · Differential
epriestley closed T4452: Can't add code-review comments in differential's single-file view as Resolved by committing Restricted Diffusion Commit.
Mar 9 2015, 5:27 PM · Differential
epriestley added a revision to T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity: Unknown Object (Differential Revision).
Mar 9 2015, 5:02 PM · Differential
epriestley added a comment to T3669: Make it easier to remember to submit inline comments when updating a diff.

Yeah, basically. Presumably at some level of <blink /> tag, no first-time user will get the model wrong, but then every user pays the price for it forever. That mock feels like too high a price to pay, although maybe there's a 1/2 as blinky version that's more obvious than "Not Submitted Yet" + dashed border.

Mar 9 2015, 3:45 PM · Design, Differential
epriestley added a comment to T3669: Make it easier to remember to submit inline comments when updating a diff.

One possible approach is to overkill the draft-ness so hard that no reasonable user being can possibly miss it:

Mar 9 2015, 3:41 PM · Design, Differential
epriestley added a comment to T7503: Change all the colors in Differential.

We have at least one piece of feedback from a red/green colorblind user that the current color scheme doesn't cause a problem (see T3127#32078), although it's possible this wouldn't extend to the unified view.

Mar 9 2015, 3:44 AM · Design
epriestley added a revision to T6695: Differential view for adding an empty file looks wrong: Unknown Object (Differential Revision).
Mar 9 2015, 12:47 AM · Differential
epriestley closed T6857: Moved file is showing incorrectly in Differential as Resolved.

This was fixed by D11970.

Mar 9 2015, 12:38 AM · Differential
epriestley added a revision to T7446: When a revision requires a CLA, hide the text of the diff: Unknown Object (Differential Revision).
Mar 9 2015, 12:36 AM · Differential

Mar 8 2015

epriestley closed T7513: new scrollbars: In Haunted Comment Panel, both scrollbars share position as Resolved by committing Restricted Diffusion Commit.
Mar 8 2015, 11:34 PM · Differential
epriestley added a revision to T7513: new scrollbars: In Haunted Comment Panel, both scrollbars share position: Unknown Object (Differential Revision).
Mar 8 2015, 10:34 PM · Differential
epriestley added a revision to T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity: Unknown Object (Differential Revision).
Mar 8 2015, 10:28 PM · Differential
epriestley added a revision to T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity: Unknown Object (Differential Revision).
Mar 8 2015, 9:01 PM · Differential
epriestley added a revision to T1460: Add "Done" link to an inline comment: Unknown Object (Differential Revision).
Mar 8 2015, 8:09 PM · User Delight, Differential
epriestley added a comment to T1460: Add "Done" link to an inline comment.

For the actual inline, here's the set of elements I'd like to try starting with:

Mar 8 2015, 7:53 PM · User Delight, Differential
epriestley closed T6323: Provide UI indication you've reached the end of a Diff's comments as Wontfix.
  • Value seems very low.
  • Behavior is generally consistent with "Find Next" in many programs, including browsers.
  • It's a pain to compute "Next (Back to Top)" because inlines can become visible or invisible in response to a bunch of events (e.g., adding and removing comments, showing and hiding files, new files loading).
  • There may be only one inline, which would produce something goofy like "Prev (Wrap to Bottom) * Next (Back to Top)" and probably need to be special cased, further raising the complexity of the feature.
  • Use case isn't very compelling: there shouldn't ever be a lot of lint comments. If linters are raising nontrivial levels of false positives, delete them. Lint has powerful tools for excluding files, adjusting severities, etc., and particularly after .arclint these are relatively easy to configure.
Mar 8 2015, 7:34 PM · Design, Differential
epriestley closed T5742: Add commentor column to "Revision Update History" table as Wontfix.

We're going to explore other approaches. I don't anticipate building this, specifically.

Mar 8 2015, 6:42 PM · Differential
epriestley added a comment to T6323: Provide UI indication you've reached the end of a Diff's comments.

@chad, do you have thoughts on where you want to go with this? I'm definitely WONTFIX on it -- e.g., neither Chrome nor Safari nor TextMate give a specific visual indicator when wrapping under "⌘G", so this feels consistent to me. I can't recall any application giving a specific wrap indication except nano, which just says [Search Wrapped].

Mar 8 2015, 6:40 PM · Design, Differential
epriestley claimed T4452: Can't add code-review comments in differential's single-file view .
Mar 8 2015, 6:25 PM · Differential
epriestley added a revision to T4452: Can't add code-review comments in differential's single-file view : Unknown Object (Differential Revision).
Mar 8 2015, 6:25 PM · Differential
epriestley added a revision to T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity: Unknown Object (Differential Revision).
Mar 8 2015, 6:21 PM · Differential
epriestley added a comment to T7508: "Create New User" should be shown to all users.

I think we're nearly consistent about that, although @joshuaspence caught at least a few other cases where we're missing the disabled style and there are probably a few cases that are arguable or ambiguous (for instance, user creation is no longer necessarily admin-only, it's just admin-only by default and at-most-admin-only in all reasonable setups we're aware of in the wild).

Mar 8 2015, 5:33 PM · People
epriestley added a revision to T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity: Unknown Object (Differential Revision).
Mar 8 2015, 1:03 PM · Differential
epriestley added a revision to T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity: Unknown Object (Differential Revision).
Mar 8 2015, 11:16 AM · Differential
epriestley added a comment to T7507: Should return to previous page after clicking "OK".

The expected behavior is for the dialog to use a workflow. In general, disabled actions should use a workflow so that dialogs show on the same page when the actions are clicked.

Mar 8 2015, 11:04 AM · Policy
epriestley closed T7509: arc lint config for linting only files in the commit as Invalid.

This is the default behavior. Use --everything or specify paths to lint all files.

Mar 8 2015, 11:02 AM · Arcanist
epriestley added a comment to T7508: "Create New User" should be shown to all users.

In a lot of cases, a user will have permission on some objects but not on others. For example, you can often "Edit Project" on some projects, but not on others. In these cases, the intended behavior is to always to show the action, but show it with a disabled style if it isn't available on that particular object. This makes the UI more consistent (the same actions are always available, and the actions are always in the same positions) and more discoverable (you can see that the action is available) and more comprehensible (you can click the action to figure out why you aren't allowed to take it).

Mar 8 2015, 10:59 AM · People

Mar 7 2015

epriestley closed T7505: gg as Spite.
Mar 7 2015, 11:09 PM · Documentation, GitHub, Guides
epriestley closed T7505: gg, a subtask of T4482: Document one or two reasonable workflows for Github repositories, as Spite.
Mar 7 2015, 11:09 PM · Guides, Documentation, GitHub
epriestley reopened T4921: Detect when webserver configuration does not forward HTTP authorization as "Open".
Mar 7 2015, 11:09 PM · Setup
epriestley added a revision to T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity: Unknown Object (Differential Revision).
Mar 7 2015, 10:00 PM · Differential
epriestley added a revision to T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity: Unknown Object (Differential Revision).
Mar 7 2015, 7:37 PM · Differential
epriestley added a revision to T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity: Unknown Object (Differential Revision).
Mar 7 2015, 7:16 PM · Differential
epriestley added a revision to T7014: Annouce Persistent Chat option in Conpherence: Unknown Object (Differential Revision).
Mar 7 2015, 5:46 PM · Conpherence
epriestley claimed T7083: Scrollbar ends seemingly underneath page, gets cut off.
Mar 7 2015, 5:35 PM · PHUI
epriestley closed T7176: Refreshing the page in Chrome no longer jumps to the correct position as Wontfix.

I don't have a reasonable way to fix this and the use case doesn't seem very compelling (i.e., we should make Harbormaster builds easier to monitor without reloading the page).

Mar 7 2015, 5:34 PM · PHUI
epriestley added a comment to T7494: Scrolling is... super bad in Chrome?.

@qgil, I believe the sidebar thing should be fixed at HEAD -- see T7052.

Mar 7 2015, 3:49 PM · PHUI
epriestley added a comment to T7494: Scrolling is... super bad in Chrome?.

Doesn't repro for me either.

Mar 7 2015, 9:27 AM · PHUI
epriestley updated subscribers of T4721: Improve user-facing documentation for Passphrase.
Mar 7 2015, 9:17 AM · Documentation, Passphrase
epriestley merged task T7495: Documentation for Passphrase into T4721: Improve user-facing documentation for Passphrase.
Mar 7 2015, 9:17 AM · Passphrase, Documentation
epriestley added a comment to T7482: Add "Tokens Received" query.

"Leader Board" essentially is that -- by design, tokens are given to objects, not users. For example, there's no clear user to credit with a token when you give a token to a wiki page with several editors.

Mar 7 2015, 12:37 AM · Tokens

Mar 6 2015

epriestley added a comment to T7478: Inbound email is wrapped when sent from Gmail.

Modulo that terminal quote, I conclude this is a problem with your client.

Mar 6 2015, 11:10 PM · Mail
epriestley added a comment to T7478: Inbound email is wrapped when sent from Gmail.

PBR American Apparel selvage, banjo actually next level chia gentrify cronut authentic. Shabby chic ennui health goth Banksy Intelligentsia PBR. Wolf irony health goth pug lumbersexual High Life cliche, heirloom Neutra. Narwhal slow-carb retro, organic Brooklyn typewriter Portland. Quinoa kogi literally, cardigan paleo viral vinyl occupy photo booth sartorial Brooklyn semiotics Shoreditch wayfarers drinking vinegar. Pour-over VHS flexitarian paleo pickled. Messenger bag Blue Bottle Kickstarter narwhal, gluten-free kogi banh mi Bushwick Godard fanny pack quinoa synth skateboard occupy chambray.

Mar 6 2015, 11:08 PM · Mail
epriestley added a comment to T7478: Inbound email is wrapped when sent from Gmail.

Sending myself an email.

Mar 6 2015, 11:07 PM · Mail