Page MenuHomePhabricator
Create Task
Maniphest T7520

Highlighted code doesn't stay highlighted when leaving a comment
Closed, SpitePublic
Actions

Description

Unclear if bug or feature. If I select a few lines of code to comment on, move the mouse into then out of the comment box, the highlight goes away (and then back on when my mouse goes into the comment area). It feels like a bug, maybe, that it should stay highlighted until I hit Ready or Cancel.

Event Timeline

chad created this task.Mar 10 2015, 2:05 AM
chad raised the priority of this task from to Needs Triage.
chad updated the task description. (Show Details)
chad added a project: Differential.
chad added subscribers: chad, epriestley.
epriestley added a comment.Mar 10 2015, 2:22 AM

This is intended. In particular, if you highlight other inline comments we'll update the reticle to show you the code they cover, if you need a reminder. Code can also be kind of hard to read through the reticle. We could lock it while the editor is active if you haven't moused over anything, but it seems reasonable to me as-is?

chad added a comment.Mar 10 2015, 2:23 AM

Is it new or do I just not leave many comments, haha.

epriestley added a comment.Mar 10 2015, 2:27 AM

Pretty sure I didn't change that, although it's possible I did by accident.

epriestley added a comment.Mar 10 2015, 2:28 AM

I did consciously think about the behavior, but it's possible I did that after accidentally changing it. However, there wasn't any code to save/restore the focused element so I'm like 95% sure the behavior didn't change.

chad closed this task as Spite.Mar 10 2015, 3:03 AM
chad claimed this task.

well if it bothers anyone else, at least there is a task for them to find.

Phabricator · Built by Phacility