| sophiebits | |
| Nov 4 2014, 3:16 AM |
| F229335: pasted_file | |
| Nov 4 2014, 3:16 AM |
| F229333: pasted_file | |
| Nov 4 2014, 3:16 AM |
If you click one of these Delete links…
then the comment remains inline…
and gives an error when clicking Delete (presumably because it's already been deleted):
Argument 2 passed to DifferentialInlineCommentEditController::canEditInlineComment() must be an instance of DifferentialInlineComment, boolean given, called in phabricator/src/applications/differential/controller/DifferentialInlineCommentEditController.php on line 48 and defined
| Restricted Differential Revision | Restricted Diffusion Commit |
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Resolved | epriestley | T7447 Bring inline comments forward across revision updates | ||
| Resolved | None | T6464 Deleting a pending inline comment from the preview at the bottom doesn't remove it inline |
Can confirm, basically looks like the JS zaps whatever parent node it's on, not both. You just don't notice when it's deleted above since preview just redraws itself (sans comment).