Page MenuHomePhabricator

Deleting a pending inline comment from the preview at the bottom doesn't remove it inline
Closed, ResolvedPublic

Assigned To
None
Authored By
sophiebits
Nov 4 2014, 3:16 AM
Referenced Files
F229335: pasted_file
Nov 4 2014, 3:16 AM
F229333: pasted_file
Nov 4 2014, 3:16 AM
Subscribers

Description

If you click one of these Delete links…

pasted_file (246×653 px, 45 KB)

then the comment remains inline…

pasted_file (97×480 px, 17 KB)

and gives an error when clicking Delete (presumably because it's already been deleted):

Argument 2 passed to DifferentialInlineCommentEditController::canEditInlineComment() must be an instance of DifferentialInlineComment, boolean given, called in phabricator/src/applications/differential/controller/DifferentialInlineCommentEditController.php on line 48 and defined

Event Timeline

sophiebits raised the priority of this task from to Needs Triage.
sophiebits updated the task description. (Show Details)
sophiebits added a project: Differential.
sophiebits added a subscriber: sophiebits.
chad triaged this task as Normal priority.Nov 7 2014, 11:35 PM
chad added a subscriber: chad.

Can confirm, basically looks like the JS zaps whatever parent node it's on, not both. You just don't notice when it's deleted above since preview just redraws itself (sans comment).