Page MenuHomePhabricator
Create Task
Maniphest T7507

Should return to previous page after clicking "OK"
Closed, ResolvedPublic
Actions

Description

I think that it is a little odd that after clicking "OK" on a "You Shall Not Pass" dialog, I am redirected back to the home page. I think it makes more sense to be redirected to the previous page that was being viewed.

For example, if I go to https://secure.phabricator.com/diffusion/ and click on "New Repository", I end up on https://secure.phabricator.com/diffusion/new/ with a "You Shall Not Pass" dialog. I click "OK" and am taken back to https://secure.phabricator.com/, whereas I would expect to be taken back to https://secure.phabricator.com/diffusion/.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Related Objects

Event Timeline

joshuaspence created this task.Mar 8 2015, 4:33 AM
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: PHUI.
joshuaspence added a subscriber: joshuaspence.
chad edited projects, added Policy; removed PHUI.Mar 8 2015, 6:01 AM
epriestley added a subscriber: epriestley.Mar 8 2015, 11:04 AM

The expected behavior is for the dialog to use a workflow. In general, disabled actions should use a workflow so that dialogs show on the same page when the actions are clicked.

epriestley assigned this task to lpriestley.Mar 22 2015, 12:06 PM
lpriestley added a revision: Restricted Differential Revision.Apr 26 2015, 6:58 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Apr 26 2015, 7:01 PM
epriestley added a commit: Restricted Diffusion Commit.
lpriestley mentioned this in T7499: "New Build Plan" should be greyed out if not allowed by policy.Apr 26 2015, 7:20 PM
Phabricator · Built by Phacility