Page MenuHomePhabricator

Some UIs activate dialogs incorrectly when Quicksand is active
Closed, ResolvedPublic

Description

This is probably going to be hard to nail down, but a lot of controllers do something like this:

if ($request->isAjax()) {
  return a dialog;
} else {
  return a page;
}

This is overbroad, because Quicksand requests are Ajax and Workflow but shouldn't normally activate specialized pathways.

We need to go hunt all of these down and change isAjax() to some method like isWorkflow() && !isQuicksand(), so that they activate only on real workflow, or maybe make Quicksand stop detecting as Ajax.

In general, these classifications are probably more confusing than they should be.

Event Timeline

epriestley raised the priority of this task from to Low.
epriestley updated the task description. (Show Details)
epriestley added a project: Quicksand.
epriestley added a subscriber: epriestley.

Creating tasks is affected by this in a particularly visible way.