Page MenuHomePhabricator

Polish for Conpherence Durable Column
Closed, DuplicatePublic

Description

I'm probably going to be more of a pain in the butt than usual with Durable Column interactions because it's super important for me to get this feeling really polished. I'm going to use this task as a list of "polish" items to be discussed as I'm sure their importance is likely debatable considering our usual workload / prioritization. One reason I probably feel more pressure to make this pure awesome-sauce is that I feel it's one of the core features when pitching Phabricator (team communication).

  • Sending a new message doesn't feel light / fun.

Some of this is primarily the loading mask, which refreshes everything. Regardless of back-end mechanics, posting should seem instant, at least from a user point of view.

  • Remarkup is making everything broken

This is probably all CSS, but I'll want to go through and stress test a number of remarkup UI elements and make sure they play well. For example, large macros, embedded objects (Pholio, Paste, Hovercards) all needs to have some attention paid to them so it's not broken looking 10% of the time.

  • Hovercards

These look bad nearly every time, though the fix will fix the issue everywhere (see T7524).

  • TDB

I'll add to this as I come across minor bits of polish.

Event Timeline

chad raised the priority of this task from to Needs Triage.
chad updated the task description. (Show Details)
chad added projects: Conpherence, Design.
chad added subscribers: chad, epriestley, btrahan.

On sending messages stuff

Some of this is primarily the loading mask, which refreshes everything.

Actually, just the latest transaction(s) are ajax'd in. It's worth noting this could be many transactions as even with Aphlict we can't guarantee the user's laptop wasn't offline or what have you.

Regardless of back-end mechanics, posting should seem instant, at least from a user point of view.

The tricky part is remarkup. I don't think writing remarkup again in JS is a tenable, so we basically have to do one round trip at some point. Maybe there's something that can be done with a draft copy or something, where we keep a cached rendered version via the draft stuff, or we can snap in the plain version and have the remarkup come back. I'll poke at this a little as draft is on my radar for T7014.

chad triaged this task as Normal priority.

I've had a bunch of stuff going on today, but is the "pop in" where the column loads after the page and then the whole layout jumps intentional? It feels a lot worse to me than the behavior I think we had before (empty column which loads content but doesn't reflow the whole page).

(I'm also hitting some bugs with it, but those are likely easy to fix.)

AFAIK the "pop in" is an unintentional regression.