When a Hovercard draws in, if the object is near a screen edge, it will frequently get cut off. I assume this is just some minor math that needs to be accounted for in the javascript.
Description
Description
Revisions and Commits
Revisions and Commits
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Resolved | btrahan | T7565 Ship Conpherence v2 | ||
| Open | None | T7569 Support Feed/Notifications in Conpherence | ||
| Resolved | btrahan | T7572 Ship Durable Chat Column | ||
| Resolved | btrahan | T7524 Hovercards near screen edge should re-adjust placement |
Event Timeline
Comment Actions
Hmm, this is going to be pretty tricky to fix for just one view of conpherence. Given T7531 sound like it might fix the CSS and how gross this is to get done technically, tossing back into the pool for a bit...
I think to get this for all of Conpherence
- ConpherenceTransactionComment can implement newMarkupEngine where it does a `setConfig('disable-hovercards', true);
- PhabricatorObjectRemarkupRule can re-act to this config in renderHovertag, electing not to setPHID on the PHUITagView if this config is true.
- maybe hovercards get rendered other ways in remarkup? same basic fix though
...and from there to get it for just the column view
- Re-work ConpherenceTransactionComment further to optionally set the config if some "fullDisplay" member variable is false
- Hi-jack the full_display variable inside ConpherenceTransactionView::renderTransactions to get passed to the transaction comment object
It seems somewhat inevitable that we're going to have to hack open the transaction parsing / rendering stack (or write a new one) to hit the various product goals.
Comment Actions
We can cheat and do a:
if (e.getNode('durable-column')) {
// This is in the durable column, so don't show a hovercard.
return;
}..in JS without changing the rendering. But it would be nice to just make these work, too.
Comment Actions
You want hovercards to work? Yeah I guess that is possible, and it'd fix a number of other Hovercard display issues.
Comment Actions
Yeah, I think remarkup should work the same everywhere, and hovercards is feature of remarkup.
Should I morph this into something to fix the display of the hovercards or does T7531 cover this?
Comment Actions
I would swear we already have a "Hovercards get cut off" ticket somewhere. Basically they just need better display math behind them to not cut off on edges.