Page MenuHomePhabricator

Linking to lines in a diff
Open, NormalPublic

Description

Would be nice to have a feature similar to Github's link to line (https://github.com/gitlabhq/gitlabhq/pull/1937). epriestley thinks this is best done after T2009

Related Objects

Event Timeline

dougluce updated the task description. (Show Details)
dougluce raised the priority of this task from to Needs Triage.
dougluce added a project: Differential.
dougluce added a subscriber: dougluce.

Note that you can already link to a line in the Diffusion browse view, where this problem is much simpler. Here's an example:

https://secure.phabricator.com/diffusion/P/browse/master/src/applications/pholio/controller/PholioMockViewController.php;3e946140d36fe83c321ffd830512a85cbf61d77b$8-10

This is slightly more difficult in the diff views and in Differential, primarily because we need to expand context when a user links to a line which is hidden behind "show more context".

epriestley edited this Maniphest Task.Feb 10 2014, 10:18 PM
epriestley triaged this task as Normal priority.Feb 10 2014, 10:18 PM