Page MenuHomePhabricator

Spacing is totally wonky when viewing reviews on android browser
Closed, WontfixPublic

Description

[I put this under differential because that's where I saw it, but it may apply to all applications.]

The spacing of differential reviews when viewing them on my android phone is really wonky. I will upload an image showing what it looks like.

I am using a nexus prime, maybe?, I'm not sure actually, but a nexus something. I believe it's running ice cream sandwich. This is definitely with the stock android browser, and not with android chrome.

Event Timeline

csilvers raised the priority of this task from to Needs Triage.
csilvers updated the task description. (Show Details)
csilvers added a project: Differential.
csilvers attached 1 file(s): Restricted File.
csilvers added a subscriber: csilvers.

It just occurred to me the problem may be the font used is not being downloaded or rendered on my phone properly. Not sure if that is my fault or not.

epriestley added a subscriber: epriestley.

We're going to implement 1-up views for devices, this isn't expected to work reasonably yet (although that failure mode is bananas).

Most pages are marked device-compatible and send some meta tags that prompt phones to do more-or-less reasonable things. This is one of the pages that doesn't, so that might be part of the issue.

Yeah, I don't actually mind the 2-up view -- I don't know what the 1-up view will look like, so can't say whether I'd prefer to use that or the 2-up view on my mobile device -- it's just the spacing. If magic meta tags could fix it, that would be da bomb!

Ice Cream Sandwich is a few years (and many versions) old. I can't see a reason to support such a specific OS/Browser. I think overall {T2004} would resolve this though so I'll merge this in.

I will get out my Nexus 4 and see how things look though, it might be something simple regardless.

✘ Merged into T2004.

I misspoke, my apologies. I'm actually on jellybean. Since kitkat is just now rolling out, and that in a limited way, I think it's pretty accurate to say I'm on the latest version of android. While I don't know for sure, I suspect that everyone who uses phabricator on android has the same user experience that I do. (If not, then it may be a problem with my phone in particular, though I don't know what that problem would be.)

I'm reopening because I think this can be fixed in a way that's much simpler than T2004, which I'm guessing will take a while. I'm hoping it's as simple as some meta tags which affect how the browser does spacing.

(That said, kitkat is replacing the stock android browser with chrome, and the text displays fine in chrome-on-android, so if you wait out the problem it will eventually go away. :-) )

I only have Chrome on my Nexus, and I can’t seem to find anywhere on Google to tell me what the “default” Android browser is called so I can download it. What is it on your device?

The default android browser is called 'Browser', and I believe is installed on default on all android phones (it's the browser used in WebView). My phone has a search bar at the top of every screen; if I type a query into that, it displays search results using the default browser. When I type a url into the search bar, it takes me to that page using the default browser as well. I don't know if your experience would be the same as mine, or different.

Chrome is my default on my Nexus 4. There is no means of downloading "Browser" (it's not in the store) except by rooting my device and installing an older Android.

Maybe an emulator will work?

Yeah, if you don't have 'browser' showing up as an installed app for you, there's probably no way of getting it.

You could definitely use an emulator; I don't know how much work you want to go through to debug this. I think the standard emulator is http://androvm.org/blog/download/

(If you do install the androvm emulator, the browser is the 'world' icon in the lower right corner at http://androvm.org/wp-uploads/2012/11/step6-359x300.png).

It is a slow download. I have a Nexus 4 and 7 and they both are on 4.3 and don't have that app. I only have these devices for testing so I don't have to use an emulator, so yeah, money well spent haha.

I have it running enough on VMWare (and see the bug), which was much easier to get up and going than adrovm. Just download an ISO and install. I might dink around tomorrow on it, or this weekend, but if it's anything other than some CSS, we'll likely be out of luck. I'd rather just ship Differential Mobile for Everyone (tm) if I'm going to spend a day on it.

So there are a few options for you.

  1. Use a more up to date browser.
  2. In your personal monospace settings in Phabricator, remove "Monaco", monospace

These two fonts, either together or solo, cause it to wig out. It's not something I think we'd want to fix in Phabricator itself (detect that platform and build another default) as it's effectively an EOL browser. The correct solution for us is still preferably T2004

OK, understood. Thank you for taking the time to look into it! I'm glad that there's a straightforward workaround.

csilvers claimed this task.