(But almost no users in General Chat are actually disabled, I think -- all the dots are for unverified users. Not sure if those should act the same, since we probably wouldn't sort away/busy users to the bottom? Also, why not just kick those users out in normal cases?)

Maybe just sort them to the bottom?

(And I think "Conpherence as an announcement tool" is a very marginal use case anyway -- today, Phame is probably better already?)

That seems reasonable to me. We could implement a "read-only" equivalent later by having a flag like "require edit permission to send messages to this room" if we need it. That probably makes more sense anyway -- I can't really think of any use cases where a room is sort-of read-only, but the users who can post to it are different than users who can edit it.

Oh, sorry, I meant: if security.alternate-file-domain was configured, that prevented this problem.

Well, I do not have configured the security,alternate-file-domain.
But it works now for me with this fix :D

I'm reasonably sure that fixes it; let us know if you're still seeing issues after updating.

(This likely would not be reproducible on any instance which has security.alternate-file-domain configured, which is why it wouldn't reproduce here or in the Phacility cluster.)

This reproduces somewhat-reliably for me with Quicksand (Persistent Chat) on.

I'll generate a best guess patch later today.

I think it's a race condition with quicksand

@flippingtables: Do you access to your phabrictor intance through a loadbalancer?

Ran into this too.

Oh, no, T7579 / T7580 are very slightly different. These probably do need updates at some point but I'll leave 'em for now

I'm going to merge this into T7580 since I think that's the same task?

Could phabricator.base-uri setting affect this? Our install is accessed via http://phab.domain.com:port/.

Our users can confirm this behavior. With active persistent chat, the Lightbox is not working. If it is disabled, its working as expected.

Our users can confirm this behavior. With active persistent chat, the Lightbox is not working. If it is disabled, its working as expected.

No easy way, but we'll keep a lookout for how common this request is and roll with it if needed.

I don't suppose there is any easy way to add this to a users preference settings? I often compose complex stuff in conpherence and am continually sending incomplete messages to the chat...

I tried stopping aphlict notification server. Stopping it has no effect, the issue still reproduces if I have Persistent Chat enabled.

Yes we are. I can try to stop the notification server tomorrow, will see if that makes any difference.

I'm not finding anything magical that triggers the error at least against this server or my test server. Are you all running notification servers?

@chad I cannot reproduce the issue on this server.

@chad when persistent chat is open here the preview works fine. We also use Mac/Chrome.

yeah this is tricky since Conpherence has it's own separate notification channel. I was hoping to just pop these in with standard Mailtags, which sort of works, but is also sort of confusing.

Going to pass on this overall, not sure it's worth effort an I'd rather 'pin' favorites that be able seem room #10 from the list of most recent rooms. Happy to revisit if it seems to scratch an actual itch users have.

Closing since most of the v4 UI is complete and there will only be minor polish going forward with other tasks.

I can't break this any more, but if it pops up again can re-open.

I think it sort-of does something if you upload an irregularly-sized image (say, 100x200) instead of a square image. But I don't think it's particularly useful or works well even in that case, and I definitely support getting rid of it.

Should basically just be UI, yeah.

At least search across all threads I can see works, so It should be all UI to add it per room. I'll take a stab at this next unless there is something other than UI blocking.

Seems like all the pieces are here except UI, @epriestley ?

oh god, this looks like a lot of crazy js.