HomePhabricator

Fix a Quicksand/Lightbox contention issue

Description

Fix a Quicksand/Lightbox contention issue

Summary:
Fixes T11785. Lightbox calls JX.Stratcom.pass() to let other handlers react, but should not. At least today, we never put, e.g., links inside a lightbox.

This code appears in the original commit so it was probably just copy/pasted from somewhere and I missed it in review.

(Or there's some edge case I'm not thinking of and we'll figure it out soon enough.)

Additionally, blacklist /file/data/ from Quicksand naviagtion: Quicksand should never fetch these URIs.

Test Plan:

  • Disabled security.alternate-file-domain.
  • Enabled Quicksand ("Persistent Chat").
  • Clicked an image thumbnail on a task.
    • Repeated that until things flipped out a bit.
    • After the patch: no issues.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11785

Differential Revision: https://secure.phabricator.com/D16884

Details

Provenance
epriestleyAuthored on Nov 17 2016, 12:54 AM
epriestleyPushed on Nov 17 2016, 1:10 AM
Reviewer
chad
Differential Revision
D16884: Fix a Quicksand/Lightbox contention issue
Parents
rPd2f3e7f7f3ab: Remove sidenav from Workboards
Branches
Unknown
Tags
Unknown
Tasks
T11785: Clicking on images for lightbox won't load with Persistent Chat enabled
Build Status
Buildable 14538
Build 18962: Run Core Tests