@epriestley don't think I've written a PHP migration before, can you spot check this before I fire it up on my test install. :D

This kind of thing is messy since if we put this in the migration, we can't delete the getImages() code (the migration will stop running as soon as we do, since the method won't exist anymore).

Instead, you should probably do this:

• Use LiskRawMigrationIterator instead of LiskMigrationIterator.
• Access imagePHIDs directly, then phutil_json_decode() it manually.
• Use idx($that_thing, 'original') to get the original PHID (if I'm tracing the logic correctly).
• Everything else is correct.

You can look at 20161004.cal.01.noepoch.php for a (more complicated) example of this. I had to do the same thing there because I plan to delete most of the columns/methods it references in a future chnage.

yeah, that was my intention, do this all at the DB level so I would be able to delete all the old code.

It's possible that there are no transactions left by the time we get here,, so end($xactions) might return false because $xactions is an empty array().

We can have no transactions if they were all removed because none of them did anything (e.g., set the title to the same thing, set the subtitle to the same thing, etc). We just drop transactions that don't have any effect. In this case, resetting an already-reset image is probably just being dropped.

I think we can just do something like this at the top?

if (!$xactions) {
  return $xactions;
}