Page MenuHomePhabricator

Disabled participants shouldn't be listed in the sidebar
Closed, WontfixPublic

Description

Maybe?

Event Timeline

Maybe just sort them to the bottom?

(But almost no users in General Chat are actually disabled, I think -- all the dots are for unverified users. Not sure if those should act the same, since we probably wouldn't sort away/busy users to the bottom? Also, why not just kick those users out in normal cases?)

Do we not send email to unverified people now?

(Although I think the dots appeared before that change, when you enabled auth.require-email-verification to combat printer faxers.)

Do they get notifications? Or we cut out completely? Basically I'd like to remove the dot for email-not-verified if possible.

Like if we just send notifications if you're not verified, I think that's sufficient

If auth.require-email-verification is off, they receive notifications in Phabricator itself.
If auth.require-email-verification is on, they can not log in or see anything until they verify their email addresses.

We can remove the dot, but I worry it may be confusing to new users who are onboarding and, e.g. assign reviews or @mention coworkers who haven't bothered to sign up yet. They won't necessarily understand the notification rules and without the dot, they may learn something about Phabricator which isn't true ("Phabricator doesn't send my co-wokers email, I need to go ask them in person if I want them to respond to something").

Globally, I think that essentially only this install (and perhaps a handful of other open source installs) have a lot of grey dot unverified users. On a normal install, especially one created after the new rules, users will very rarely/briefly be unverified.

What's your concern with the way things currently work? Just that we have a lot of grey dots on this install? Would kicking all unverified users out of General Chat solve things?

At a minimum I'd prefer a different icon than administratively disabled. Mostly, I don't think it matters this information is conveyed, since it sounds like it's expected to be temporal?

Maybe like, yellow or orange... indigo... vermillion?

"Busy" and "Away" are temporal too. I think all three states are important: they indicate that you shouldn't expect a response from the user.

The "Unverified" state may not always go away on its own quickly: sometimes people don't go sign up for stuff that shows up in their email inbox, and need to be hassled in person. They may have been invited with the wrong email and have no idea they have an account. Both of these cases point toward manual intervention to remove the state, and the grey dot can help provide a clue about that.

We can change the dot to be some other color easily enough.

Orange and red/vermillion are already used for "Away" and "Busy", and I think green would be confusing (similar to "online"), so maybe indigo/pink/blue/violet?

There are probably a couple of tags on hovercards and maybe user profiles which should be color-coordianted for consistency.

"RU SUB" DKP are the best DKP.

I played vanilla WOW for a bit but I was never got to the part with raiding.

Yup, no one in general chat is disabled.

chad claimed this task.