Page MenuHomePhabricator
Differential D16665

Remove Crop Image from Conpherence Edit UI
ClosedPublic
Actions

Authored by chad on Oct 4 2016, 8:58 PM.
Tags
None
Referenced Files
F15457562: D16665.id40122.diff
Sun, Mar 30, 5:16 PM
F15457561: D16665.id40119.diff
Sun, Mar 30, 5:16 PM
F15457560: D16665.id.diff
Sun, Mar 30, 5:16 PM
F15456423: D16665.diff
Sun, Mar 30, 9:35 AM
F15446034: D16665.id40122.diff
Thu, Mar 27, 4:55 PM
F15446032: D16665.id40119.diff
Thu, Mar 27, 4:55 PM
F15446031: D16665.id40118.diff
Thu, Mar 27, 4:55 PM
F15446030: D16665.id.diff
Thu, Mar 27, 4:55 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T11730: Remove image crop from Conpherence
Commits
rP524906a4396a: Remove Crop Image from Conpherence Edit UI
Summary

Ref T11730. Removes the front end crop feature. Will follow up with proper removal, but this seems broken outright.

Test Plan

Edit a room, don't seen "Crop" feature. Upload new photo, works fine.

  • grep for ConpherencePicCropControl
  • grep for aphront-crop

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 40118.Oct 4 2016, 8:58 PM
chad retitled this revision from to Remove Crop Image from Conpherence Edit UI.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T11730: Remove image crop from Conpherence.
Herald added a subscriber: Korvin. · View Herald TranscriptOct 4 2016, 8:58 PM
chad updated this revision to Diff 40119.Oct 4 2016, 9:02 PM
  • I guess, remove code too
chad edited the test plan for this revision. (Show Details)Oct 4 2016, 9:06 PM
epriestley accepted this revision.Oct 4 2016, 11:22 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 4 2016, 11:22 PM
Closed by commit rP524906a4396a: Remove Crop Image from Conpherence Edit UI (authored by chad, committed by chad). · Explain WhyOct 4 2016, 11:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
2 lines
applications/
conpherence/
controller/
4 lines
view/
webroot/
rsrc/
js/
core/

Diff 40122

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...
View Options

src/applications/conpherence/view/ConpherencePicCropControl.php

Loading...
View Options

webroot/rsrc/js/core/behavior-crop.js

Loading...
Phabricator · Built by Phacility