Check is viewer is a participant before showing count
ClosedPublic
Actions

Authored by chad on Apr 12 2017, 8:24 PM.

Tags

None

Referenced Files

	F15390985: D17664.id42486.diff
	Sat, Mar 15, 7:41 AM

	F15341399: D17664.diff
	Sun, Mar 9, 8:03 PM

	Unknown Object (File)
	Feb 10 2025, 11:07 PM

	Unknown Object (File)
	Feb 9 2025, 3:45 AM

	Unknown Object (File)
	Feb 9 2025, 3:45 AM

	Unknown Object (File)
	Feb 9 2025, 3:45 AM

	Unknown Object (File)
	Feb 9 2025, 3:45 AM

	Unknown Object (File)
	Feb 2 2025, 5:39 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12485: Conpherence MenuItem

Commits

rP6bf595b95154: Check is viewer is a participant before showing count

Summary

In Conpherence ProfileMenuItem we show an unread count if you're a participant, but all message count if you're not. Just remove that.

Test Plan

Log out of room in Conpherence, leave messages on second account, check menu item on both accounts.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Apr 12 2017, 8:24 PM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 12 2017, 8:24 PM

epriestley accepted this revision.Apr 12 2017, 8:25 PM

This revision is now accepted and ready to land.Apr 12 2017, 8:25 PM

Harbormaster completed remote builds in B16415: Diff 42484.Apr 12 2017, 8:25 PM

Closed by commit rP6bf595b95154: Check is viewer is a participant before showing count (authored by chad, committed by chad). · Explain WhyApr 12 2017, 8:27 PM

This revision was automatically updated to reflect the committed changes.

I now no longer need the menu in the header. 😄

chad added a task: T12485: Conpherence MenuItem.Apr 12 2017, 8:47 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

menuitem/

PhabricatorConpherenceProfileMenuItem.php

9 lines

Diff 42486

View Options

src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php

Check is viewer is a participant before showing countClosedPublicActions