Page MenuHomePhabricator

Sam2304 (Sam Martin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 28 2016, 10:25 AM (176 w, 4 d)
Availability
Available

Recent Activity

Mar 3 2017

Sam2304 awarded T9530: Release Server / Workflow app / Future of Releeph a Love token.
Mar 3 2017, 11:35 AM · Restricted Project, Harbormaster

Feb 8 2017

fosskevin awarded T12231: Projects with very long names cause menu bar to overlap workboard a Like token.
Feb 8 2017, 3:45 PM · Workboards, Bug Report
Sam2304 added a comment to T12231: Projects with very long names cause menu bar to overlap workboard.

Thanks for testing @jcox!

Feb 8 2017, 3:27 PM · Workboards, Bug Report
Sam2304 updated the task description for T12231: Projects with very long names cause menu bar to overlap workboard.
Feb 8 2017, 2:25 PM · Workboards, Bug Report
Sam2304 updated the task description for T12231: Projects with very long names cause menu bar to overlap workboard.
Feb 8 2017, 2:22 PM · Workboards, Bug Report
Sam2304 updated the task description for T12231: Projects with very long names cause menu bar to overlap workboard.
Feb 8 2017, 2:21 PM · Workboards, Bug Report
Sam2304 created T12231: Projects with very long names cause menu bar to overlap workboard.
Feb 8 2017, 2:14 PM · Workboards, Bug Report

Oct 26 2016

Sam2304 added a comment to T11623: Make Conpherence send text with bare return key, like a chatroom.

I don't suppose there is any easy way to add this to a users preference settings? I often compose complex stuff in conpherence and am continually sending incomplete messages to the chat...

Oct 26 2016, 4:17 PM · Conpherence (v4)

Sep 5 2016

Sam2304 added a comment to T11587: Explicit "Host: domain.com:80" port may conflict with reasonable Host-based redirection rules.

@epriestley You (and your team) are freaking epic. I owe you a beer (or several). If you're ever near Basingstoke, UK drop me a line!

Sep 5 2016, 3:19 PM · Arcanist, Bug Report
Sam2304 added a comment to T11587: Explicit "Host: domain.com:80" port may conflict with reasonable Host-based redirection rules.

Adjusting the redirect to use `phabricator.pt.local:80' also fixes the issue, though I have removed it as I don't think anyone here still tries to use an IP...

Sep 5 2016, 1:22 PM · Arcanist, Bug Report
Sam2304 added a comment to T11587: Explicit "Host: domain.com:80" port may conflict with reasonable Host-based redirection rules.

Confirmed, removing that redirect at the top of my apache config. also resolves the problem without changing the upstream.

Sep 5 2016, 1:17 PM · Arcanist, Bug Report
Sam2304 added a comment to T11587: Explicit "Host: domain.com:80" port may conflict with reasonable Host-based redirection rules.

I had to look that up its been so long since I fiddled with the server hosting.

Sep 5 2016, 1:09 PM · Arcanist, Bug Report
Sam2304 added a comment to T11587: Explicit "Host: domain.com:80" port may conflict with reasonable Host-based redirection rules.

Spot on! reverting that change on my arcanist client resolved any issues completely.

Sep 5 2016, 12:56 PM · Arcanist, Bug Report
Sam2304 added a comment to T11587: Explicit "Host: domain.com:80" port may conflict with reasonable Host-based redirection rules.

I can replicate the cURL error from a configured repository, its the same trace as that of the arc which command above:

[2016-09-05 10:06:49] EXCEPTION: (HTTPFutureCURLResponseStatus) [cURL/47] (http://phabricator.pt.local/api/user.whoami) <CURLE_TOO_MANY_REDIRECTS> The cURL library raised an error while making a request. You may be able to find more information about this error (error code: 47) on the cURL site: http://curl.haxx.se/libcurl/c/libcurl-errors.html#CURLETOOMANYREDIRECTS at [<phutil>/src/future/http/HTTPSFuture.php:408]
arcanist(head=stable, ref.master=9e82ef979e81, ref.stable=10e519475290), phutil(head=stable, ref.master=c8b76485ef84, ref.stable=f748cdbc8d08)
  #0 HTTPSFuture::isReady() called at [<phutil>/src/future/Future.php:37]
  #1 Future::resolve(NULL) called at [<phutil>/src/future/FutureProxy.php:34]
  #2 FutureProxy::resolve() called at [<phutil>/src/conduit/ConduitClient.php:64]
  #3 ConduitClient::callMethodSynchronous(string, array) called at [<arcanist>/src/workflow/ArcanistWorkflow.php:332]
  #4 ArcanistWorkflow::authenticateConduit() called at [<arcanist>/scripts/arcanist.php:356]
Sep 5 2016, 10:08 AM · Arcanist, Bug Report
Sam2304 added a comment to T11587: Explicit "Host: domain.com:80" port may conflict with reasonable Host-based redirection rules.

Interesting:

echo '{}' | arc --trace call-conduit --conduit-uri http://phabricator.local/ --conduit-token cli-37au4odrzomsk54zbnolivacknw3 user.whoami
 ARGV  '/home/sam/bin/phabricator-tools/arcanist/bin/../scripts/arcanist.php' '--trace' 'call-conduit' '--conduit-uri' 'http://phabricator.local/' '--conduit-token' 'cli-37au4odrzomsk54zbnolivacknw3' 'user.whoami'
 LOAD  Loaded "phutil" from "/home/sam/bin/phabricator-tools/libphutil/src".
 LOAD  Loaded "arcanist" from "/home/sam/bin/phabricator-tools/arcanist/src".
Config: Reading user configuration file "/home/sam/.arcrc"...
Config: Did not find system configuration at "/etc/arcconfig".
Working Copy: Reading .arcconfig from "/home/sam/Coding/UMC/Src/.arcconfig".
Working Copy: Path "/home/sam/Coding/UMC/Src" is part of `git` working copy "/home/sam/Coding/UMC/Src".
Working Copy: Project root is at "/home/sam/Coding/UMC/Src".
Config: Did not find local configuration at "/home/sam/Coding/UMC/Src/.git/arc/config".
>>> [0] <conduit> user.whoami() <bytes = 117>
>>> [1] <http> http://phabricator.local/api/user.whoami
<<< [1] <http> 195,683 us
<<< [0] <conduit> 195,955 us
Sep 5 2016, 10:00 AM · Arcanist, Bug Report
Sam2304 updated the task description for T11587: Explicit "Host: domain.com:80" port may conflict with reasonable Host-based redirection rules.
Sep 5 2016, 9:43 AM · Arcanist, Bug Report
Sam2304 added a comment to T11587: Explicit "Host: domain.com:80" port may conflict with reasonable Host-based redirection rules.

Further testing, the standard curl request seems to be fine:

curl http://phabricator.local/api/user.whoami \
>     -d api.token=cli-37au4odrzomsk54zbnolivacknw3
{"result":{"phid":"PHID-USER-omtmnetw55dqsgt576g7","userName":"Sam","realName":"Sam","image":"http:\/\/phabricator.local\/file\/data\/g57z5iku5s2x4rpi7k6r\/PHID-FILE-xhdrpuvh5lbu7tmkfso5\/profile","uri":"http:\/\/phabricator.local\/p\/Sam\/","roles":["admin","verified","approved","activated"],"primaryEmail":"Sam@blahblah.com"},"error_code":null,"error_info":null}

It also works from the web-conduit application in phabricator http://phabricator.local/api/user.whoami, but it fails from arc:

echo '{}' | arc call-conduit --conduit-uri http://phabricator.local/ --conduit-token cli-37au4odrzomsk54zbnolivacknw3 user.whoami
Exception
[cURL/47] (http://phabricator.local/api/user.whoami) <CURLE_TOO_MANY_REDIRECTS> The cURL library raised an error while making a request. You may be able to find more information about this error (error code: 47) on the cURL site: http://curl.haxx.se/libcurl/c/libcurl-errors.html#CURLETOOMANYREDIRECTS
(Run with `--trace` for a full exception trace.)

Weird.

Sep 5 2016, 9:38 AM · Arcanist, Bug Report
Sam2304 created T11587: Explicit "Host: domain.com:80" port may conflict with reasonable Host-based redirection rules.
Sep 5 2016, 9:19 AM · Arcanist, Bug Report

Jun 20 2016

Sam2304 added a comment to T11178: Some linters fail without a pathway forward if the PHP "xml" extension is not installed.

Damn man you're good.

Jun 20 2016, 2:09 PM · Lint, Arcanist, Bug Report
Sam2304 updated the task description for T11178: Some linters fail without a pathway forward if the PHP "xml" extension is not installed.
Jun 20 2016, 1:15 PM · Lint, Arcanist, Bug Report
Sam2304 created T11178: Some linters fail without a pathway forward if the PHP "xml" extension is not installed.
Jun 20 2016, 1:09 PM · Lint, Arcanist, Bug Report

Jun 14 2016

Sam2304 added a comment to D15976: Remove "Search Preferences".

In case anyone else is interested, I worked around this by installing a chrome extension called Shortcut Manager and added a little script to re-instate this functionality. If you want it, you can import the shortcut with the following from the settings pane of that plugin:

// ==UserScript==
// @ShortcutManager
// @name Search
// @namespace heQd49SJALoI
// @key /
// @include *phabricator*
// ==/UserScript==
queryBox = document.getElementsByName("query")[0]
queryBox.scrollIntoView()
queryBox.focus()
Jun 14 2016, 9:23 AM

Jun 6 2016

Sam2304 awarded T7787: Support "!priority high" and other email commands from "arc todo" a Like token.
Jun 6 2016, 4:58 PM · Arcanist

Jun 2 2016

Sam2304 added a comment to T4280: Embed anchor in remark up text and later link to it. .

test page1Zhttps://secure.phabricator.com/w/test_page/#derp-code/

Jun 2 2016, 5:30 PM · Remarkup
Sam2304 added a comment to T4280: Embed anchor in remark up text and later link to it. .

This appears to have had a regression at some point

Jun 2 2016, 5:18 PM · Remarkup

May 31 2016

Sam2304 added a comment to D15976: Remove "Search Preferences".

Having a jump-nav key was a boon. I just added a rule to vimium to stop listening to / on phabricator pages and was loving life... Is it likely we'll see a different key used to replace /? q looks like it would work, navigating around is much slower without /...

May 31 2016, 9:47 AM

May 27 2016

Sam2304 awarded T10374: Permit creating macros out of existing files a Like token.
May 27 2016, 9:21 AM · Restricted Project, Macros, Feature Request

May 26 2016

Sam2304 awarded T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies a Like token.
May 26 2016, 1:47 PM · Maniphest

May 25 2016

Sam2304 closed Q400: How can I generate Tables of Contents on Phriction pages? as resolved.
May 25 2016, 4:23 PM · Phriction
Sam2304 added a comment to Q400: How can I generate Tables of Contents on Phriction pages? (Answer 381).

hmm. I'll close this since everything seems to be working as intended...

May 25 2016, 4:23 PM
Sam2304 added a comment to Q400: How can I generate Tables of Contents on Phriction pages? (Answer 381).

Even more interesting, that code works fine on my instance...

May 25 2016, 4:18 PM
Sam2304 added a comment to Q400: How can I generate Tables of Contents on Phriction pages? (Answer 381).

Interesting. test_generating_toc has a TOC,

May 25 2016, 4:16 PM
Sam2304 added a comment to Q400: How can I generate Tables of Contents on Phriction pages? (Answer 381).

Thanks for getting back to me so quickly @epriestley!

May 25 2016, 4:09 PM
Sam2304 updated Q400: How can I generate Tables of Contents on Phriction pages? from to How can I generate Tables of Contents on Phriction pages?.
May 25 2016, 4:00 PM · Phriction

May 12 2016

Sam2304 awarded T10145: Adding a panel to a dashboard multiple times a Like token.
May 12 2016, 8:44 AM · Dashboards (v2), Bug Report