Page MenuHomePhabricator

Return more transaction types in Conpherence notification menu
ClosedPublic

Authored by chad on Oct 3 2016, 8:03 PM.
Tags
None
Referenced Files
F18621253: D16658.id40100.diff
Mon, Sep 15, 7:30 AM
F18094170: D16658.diff
Aug 7 2025, 10:00 PM
F18083671: D16658.id40103.diff
Aug 5 2025, 11:04 AM
F17837346: D16658.diff
Jul 26 2025, 5:13 PM
F17657272: D16658.id40100.diff
Jul 12 2025, 12:10 PM
Unknown Object (File)
May 30 2025, 2:46 AM
Unknown Object (File)
May 29 2025, 7:57 PM
Unknown Object (File)
May 28 2025, 7:59 PM
Subscribers

Details

Summary

Unclear these are worth sending, but mostly seems useful. Returns getTitle for the transaction if it's not a message. Fixes T10683

Test Plan

Leave rooms, change names, add pictures.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Return more transaction types in Conpherence notification menu.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

Personally, it seems weird that join/leave mark the room unread. I wouldn't expect title or picture changes to, either -- really, anything but a new message.

Regardless, you should be able to get a text rendering of the action like this, I think:

$text = id(clone $action_transaction)
  ->setRenderingTarget(PhabricatorApplicationTransaction::TARGET_TEXT)
  ->getTitle();

Try that instead of strip_tags()?

This revision now requires changes to proceed.Oct 3 2016, 8:12 PM
chad edited edge metadata.
  • use a rendering target
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 3 2016, 9:26 PM
This revision was automatically updated to reflect the committed changes.