Just launched a test instancepoo and everything seems fine.

We kinda did some of this, it can live on in subtasks.

Things seem better here for me, although I'm still seeing a couple issues:

This isn't the end of the world, but it's pretty bad if you have a mixture of private and less-private threads (sidebar state and main panel state are inconsistent).

very noisy

Conpherence is repainting after D17713 but notification counts aren't, yet.

I'm planning to pursue reliability (T12573) first since it's more immediately actionable (hard stuff is at the end instead of the beginning) and it will take more time to tell if we've actually fixed it.

I don't think we've done a proper sprint since Dashboards.

I suspect this "week" will actually last like two months, but I'm looking forward to sound. 🌵

Yeah I think this is more about "2 person rooms", where email is nice because it's a 1:1 interest ratio rather than general chatrooms. If we had mention email support, I'd turn off emails with the exception of two person rooms.

That makes at least some sense. My thinking was something like this:

I think I can fix this in applyFinalEffects anyways.

This costs me time every day. I get emails for some rooms, and I don't think I should have to visit them in the UI to clear the count when I come back to Phabricator. It's even more bothersome when I'm in the room and chatting that the count needs to be cleared.

I think this is basically fine as-is.

I'm going to de-scope this for now since I don't think it's terribly important, but is fairly complicated, and "v4" already has a ton of stuff in it. This should happen after UI-impacting changes like T3597 anyway.

I'm just going to merge this into T10448 since I think it's functionally identical.

Yup, no one in general chat is disabled.

"RU SUB" DKP are the best DKP.

There are probably a couple of tags on hovercards and maybe user profiles which should be color-coordianted for consistency.

Orange and red/vermillion are already used for "Away" and "Busy", and I think green would be confusing (similar to "online"), so maybe indigo/pink/blue/violet?

"Busy" and "Away" are temporal too. I think all three states are important: they indicate that you shouldn't expect a response from the user.

Maybe like, yellow or orange... indigo... vermillion?

At a minimum I'd prefer a different icon than administratively disabled. Mostly, I don't think it matters this information is conveyed, since it sounds like it's expected to be temporal?

If auth.require-email-verification is off, they receive notifications in Phabricator itself.
If auth.require-email-verification is on, they can not log in or see anything until they verify their email addresses.

Like if we just send notifications if you're not verified, I think that's sufficient

Do they get notifications? Or we cut out completely? Basically I'd like to remove the dot for email-not-verified if possible.

(Although I think the dots appeared before that change, when you enabled auth.require-email-verification to combat printer faxers.)

Right.

Do we not send email to unverified people now?