Page MenuHomePhabricator

Fix a Quicksand/Lightbox contention issue
ClosedPublic

Authored by epriestley on Nov 17 2016, 12:57 AM.
Tags
None
Referenced Files
F15553710: D16884.id.diff
Mon, Apr 28, 3:21 AM
F15540979: D16884.diff
Fri, Apr 25, 10:00 AM
F15540131: D16884.id40650.diff
Fri, Apr 25, 6:37 AM
F15534831: D16884.id40650.diff
Thu, Apr 24, 2:23 AM
F15525979: D16884.id40649.diff
Mon, Apr 21, 6:15 PM
F15520900: D16884.id40650.diff
Sun, Apr 20, 9:04 AM
F15514620: D16884.id.diff
Fri, Apr 18, 4:01 AM
F15512161: D16884.diff
Thu, Apr 17, 8:33 AM
Subscribers
None

Details

Summary

Fixes T11785. Lightbox calls JX.Stratcom.pass() to let other handlers react, but should not. At least today, we never put, e.g., links inside a lightbox.

This code appears in the original commit so it was probably just copy/pasted from somewhere and I missed it in review.

(Or there's some edge case I'm not thinking of and we'll figure it out soon enough.)

Additionally, blacklist /file/data/ from Quicksand naviagtion: Quicksand should never fetch these URIs.

Test Plan
  • Disabled security.alternate-file-domain.
  • Enabled Quicksand ("Persistent Chat").
  • Clicked an image thumbnail on a task.
    • Repeated that until things flipped out a bit.
    • After the patch: no issues.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a Quicksand/Lightbox contention issue.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 17 2016, 1:09 AM
This revision was automatically updated to reflect the committed changes.