Page MenuHomePhabricator

Fix a Quicksand/Lightbox contention issue
ClosedPublic

Authored by epriestley on Nov 17 2016, 12:57 AM.
Tags
None
Referenced Files
F19096731: D16884.diff
Thu, Dec 4, 10:55 AM
F19088417: D16884.id.diff
Wed, Dec 3, 4:06 AM
F19082701: D16884.diff
Tue, Dec 2, 12:06 PM
F18878368: D16884.diff
Nov 6 2025, 5:08 PM
F18855360: D16884.id.diff
Nov 1 2025, 5:00 AM
F18852444: D16884.diff
Oct 31 2025, 9:07 AM
F18846111: D16884.id40650.diff
Oct 29 2025, 4:42 PM
F18818104: D16884.diff
Oct 21 2025, 8:57 PM
Subscribers
None

Details

Summary

Fixes T11785. Lightbox calls JX.Stratcom.pass() to let other handlers react, but should not. At least today, we never put, e.g., links inside a lightbox.

This code appears in the original commit so it was probably just copy/pasted from somewhere and I missed it in review.

(Or there's some edge case I'm not thinking of and we'll figure it out soon enough.)

Additionally, blacklist /file/data/ from Quicksand naviagtion: Quicksand should never fetch these URIs.

Test Plan
  • Disabled security.alternate-file-domain.
  • Enabled Quicksand ("Persistent Chat").
  • Clicked an image thumbnail on a task.
    • Repeated that until things flipped out a bit.
    • After the patch: no issues.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a Quicksand/Lightbox contention issue.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 17 2016, 1:09 AM
This revision was automatically updated to reflect the committed changes.