Page MenuHomePhabricator

Fix a Quicksand/Lightbox contention issue
ClosedPublic

Authored by epriestley on Nov 17 2016, 12:57 AM.
Tags
None
Referenced Files
F14723369: D16884.id.diff
Sat, Jan 18, 12:17 AM
Unknown Object (File)
Sun, Jan 5, 11:30 PM
Unknown Object (File)
Thu, Jan 2, 1:47 AM
Unknown Object (File)
Sun, Dec 22, 10:27 AM
Unknown Object (File)
Sun, Dec 22, 2:38 AM
Unknown Object (File)
Sat, Dec 21, 3:45 PM
Unknown Object (File)
Dec 9 2024, 11:30 AM
Unknown Object (File)
Nov 27 2024, 8:10 PM
Subscribers
None

Details

Summary

Fixes T11785. Lightbox calls JX.Stratcom.pass() to let other handlers react, but should not. At least today, we never put, e.g., links inside a lightbox.

This code appears in the original commit so it was probably just copy/pasted from somewhere and I missed it in review.

(Or there's some edge case I'm not thinking of and we'll figure it out soon enough.)

Additionally, blacklist /file/data/ from Quicksand naviagtion: Quicksand should never fetch these URIs.

Test Plan
  • Disabled security.alternate-file-domain.
  • Enabled Quicksand ("Persistent Chat").
  • Clicked an image thumbnail on a task.
    • Repeated that until things flipped out a bit.
    • After the patch: no issues.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a Quicksand/Lightbox contention issue.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 17 2016, 1:09 AM
This revision was automatically updated to reflect the committed changes.