Page MenuHomePhabricator

Only show loading animation on thread change in Conpherence
ClosedPublic

Authored by chad on Oct 14 2016, 2:51 AM.

Details

Summary

Fixes the send on enter flash, only uses the Threads loading animation on changing threads, not sending a message.

Test Plan

Change threads, post a message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Only show loading animation on thread change in Conpherence.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

in theory you should do like this:

// this first
function thing() {
}

// this later
thing();

You can also trick the linter like this:

thing();

var thing = function() {
  // sneaky!
};

In practice this does not matter too much but sometimes the code is a little cleaner?

This revision is now accepted and ready to land.Oct 14 2016, 2:53 AM
This revision was automatically updated to reflect the committed changes.