Page MenuHomePhabricator
Feed Advanced Search

Dec 13 2016

epriestley moved T8623: Upgrading: Differential Hunk Migration from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:27 PM · Installing & Upgrading, Differential, Guides
epriestley closed T10000: Consider restoring Clowncopterize as Wontfix.

This hasn't moved forward in a year so I'm just going to close it. We've removed header text in the latest UI iteration, too, and I imagine the button will be replaced completely with universal send-on-enter before long.

Dec 13 2016, 4:25 PM · Differential, Feature Request
epriestley moved T10574: A pathway toward "All Reviewers Must Accept" from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:22 PM · FreeBSD, Restricted Project, Differential
epriestley moved T10967: Move Differential reviewers back to a dedicated database storage table from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:21 PM · Restricted Project, Infrastructure, Differential
epriestley moved T10968: File write failure during daemon operations caused daemons to populate a few too many diffs from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:21 PM · Files, Differential, Diffusion, Daemons
epriestley moved T11050: Allow resigning from a review you are not directly responsible for from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:20 PM · Prioritized, Restricted Project, Differential, Feature Request
epriestley moved T11114: Move Differential to EditEngine from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:20 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley moved T4045: Store diffs as binary, not UTF-8 from v2 (UI/Mobile) to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:20 PM · Restricted Project, Support Impact, Differential
epriestley moved T11660: Diff creation fails when submitting too long file paths from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:20 PM · Differential, Bug Report
epriestley moved T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion from Backlog to Future Work on the Differential board.
Dec 13 2016, 4:13 PM · Diffusion (v3), Differential, Mail
epriestley added a comment to T11708: Daemons erroneously saying "Diff does not exist".

Although it's still a little early to be sure, we appear to have fixed the policy issue with unit test failures (D17029). Not sure if that actually impacted this or not.

Dec 13 2016, 4:12 PM · Daemons, Differential, Bug Report
epriestley closed T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in as Resolved by committing Restricted Diffusion Commit.
Dec 13 2016, 3:34 PM · Files, Documentation, Bug Report
epriestley updated the task description for T12004: Scenario: Locations Application.
Dec 13 2016, 3:16 PM
epriestley created T12009: Locations Scenario: View Controller.
Dec 13 2016, 3:10 PM
epriestley created T12008: Locations Scenario: Improve New User Experience (NUX).
Dec 13 2016, 2:59 PM
epriestley created T12007: Locations Scenario: Destroying Locations.
Dec 13 2016, 2:54 PM
epriestley created T12006: Locations Scenario: Add API Support.
Dec 13 2016, 2:47 PM
epriestley created T12005: Locations Scenario: Fix a Typo.
Dec 13 2016, 2:36 PM
epriestley created T12004: Scenario: Locations Application.
Dec 13 2016, 2:27 PM
stevex awarded T5954: Modularize "Export to Excel" as a feature of ApplicationSearch a Like token.
Dec 13 2016, 1:42 PM · Custom Fields, ApplicationSearch
epriestley closed T7457: On dashboards, maybe only draw panels if all panels above them have already drawn as Wontfix.

My dashboard changed at some point and no one else seems to care, so let's wait for this to be more than an @epriestley-problem.

Dec 13 2016, 1:02 PM · Dashboards
epriestley renamed T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in from Upload Failure to Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in.
Dec 13 2016, 12:59 PM · Files, Documentation, Bug Report
epriestley added a comment to T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in.

D17037 should fix the documentation, it definitely wasn't very clear as written. That should land some time today and the docs should be updated in about 24 hours.

Dec 13 2016, 12:58 PM · Files, Documentation, Bug Report
epriestley added a revision to T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in: Unknown Object (Differential Revision).
Dec 13 2016, 12:57 PM · Files, Documentation, Bug Report
epriestley added a comment to T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in.

In the first row of that table, it appears that you have configured a storage.mysql-engine.max-size of 8 ("8 bytes"). Try using 8388608 ("8 megabytes") instead?

Dec 13 2016, 12:54 PM · Files, Documentation, Bug Report
epriestley closed T7354: Register mis-spelled domain names as Wontfix.

If you want to come up with a specific list of domains I'm happy to buy them, but there are many hundreds of domains which differ from phacility.com by only one keystroke and buying hundreds of domains isn't cheap in terms of the amount of work I have to do to do it.

Dec 13 2016, 12:53 PM · Phacility
epriestley added a comment to T12003: Explain to users how fulltext queries are parsed and executed.

I can find this task by searching for "あああああ" so the CJK stuff may not really be much of an issue anymore? Maybe just an issue with Chinese because the index doesn't know how to tokenize words?

Dec 13 2016, 12:38 PM · Search
epriestley added a parent task for T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it: T12003: Explain to users how fulltext queries are parsed and executed.
Dec 13 2016, 12:36 PM · Search
epriestley added subtasks for T12003: Explain to users how fulltext queries are parsed and executed: T6892: Invalid search result when I input less than 2 Korean character., T2632: MyISAM fulltext does not support non-latin languages and we don't warn you about it.
Dec 13 2016, 12:36 PM · Search
epriestley added a parent task for T6892: Invalid search result when I input less than 2 Korean character.: T12003: Explain to users how fulltext queries are parsed and executed.
Dec 13 2016, 12:36 PM · Elasticsearch
epriestley created T12003: Explain to users how fulltext queries are parsed and executed.
Dec 13 2016, 12:36 PM · Search
epriestley closed T6841: Maybe create an annotation for "this is strictly a template class" as Wontfix.

At least today, our error rate on this seems so low that it probably isn't worth implementing. We could take another look at it if we see more of it in the future (perhaps after we begin encouraging application development), but we haven't seen more of this that I can recall recently.

Dec 13 2016, 12:29 PM · Lint
epriestley renamed T6633: 'differential.creatediff' exception when repository paths contain SHIFT-JIS characters from 'differential.creatediff' exception to 'differential.creatediff' exception when repository paths contain SHIFT-JIS characters.
Dec 13 2016, 12:22 PM · Arcanist
epriestley closed T6611: Add history to Paste as Resolved.

Paste now shows "Old", "New" and "Diff", so you can copy/paste from "Old" to revert. Not perfect, but I think this arises relatively rarely. See T11881 for a followup.

Dec 13 2016, 12:21 PM · Restricted Project, Paste
epriestley closed T6592: Differential history mangles bullet numbering in quoted email forward as Resolved.

This is extremely old and it's not clear to me which bad cases remain -- I can't immediately find any by fiddling. If any do remain, they haven't turned up again in about two years. If you're still seeing issues, feel free to file a new task with a modern test case.

Dec 13 2016, 12:17 PM · Remarkup
epriestley closed T6443: Provide ApplicationSearch options for Dashboard as Resolved.

This picked up a few options through engine support and T11957 is adding some more. Particularly, default view is now "Authored" which I think resolves the original issue. I think the more-root problem is "Dashboards are kind of weird with all the panel copying", which is something we're aware of.

Dec 13 2016, 12:11 PM · Dashboards (v2)
epriestley closed T6389: Ship TShirt as Wontfix.

I am very sorry I am declaring t-shirt bankruptcy because I have learned it takes me over five hundred years to ship a t-shirt.

Dec 13 2016, 12:07 PM · Public & Media Relations
epriestley merged T6193: Allow Arcanist to allocate resources through Drydock into T11693: Make drydock command interfaces accessible via SSH workflows.
Dec 13 2016, 11:55 AM · Restricted Project, Drydock
epriestley merged task T6193: Allow Arcanist to allocate resources through Drydock into T11693: Make drydock command interfaces accessible via SSH workflows.
Dec 13 2016, 11:55 AM · Arcanist, Drydock
epriestley added a comment to T11957: Add MenuEngine to Home.

At some point after we get this working for Home, I want to replace the "Quick Create" menu with a similar customizable profile menu, resolving T5867.

Dec 13 2016, 11:48 AM · Profile Menu Item, Dashboards
epriestley added a subtask for T11957: Add MenuEngine to Home: T5867: Move Quick Create to MenuItemEngine.
Dec 13 2016, 11:47 AM · Profile Menu Item, Dashboards
epriestley added a parent task for T5867: Move Quick Create to MenuItemEngine: T11957: Add MenuEngine to Home.
Dec 13 2016, 11:47 AM · Design
epriestley added a project to T5657: Ability to rename flags: Contributor Onboarding.
Dec 13 2016, 11:41 AM · Contributor Onboarding, Restricted Project, Flags
epriestley renamed T6188: User should receive a nicer exception when selecting an invalid application policy like "Can Use Application: No One" from "Can Use Application" policy value "No One" useless? to User should receive a nicer exception when selecting an invalid application policy like "Can Use Application: No One".
Dec 13 2016, 11:40 AM · Policy
epriestley closed T6996: Write an `--output <file>` mode for `storage dump` which can gzip, a subtask of T7148: Allow users to export their data from Phacility, as Resolved.
Dec 13 2016, 11:38 AM · Phacility
epriestley closed T6996: Write an `--output <file>` mode for `storage dump` which can gzip as Resolved.

rCORE9d89c996844c4599afc1cec9454a71dd80a69c6c threw out the -o pipefail nonsense in CoreHostBackupWorkflow.

Dec 13 2016, 11:38 AM · Infrastructure, Phacility
epriestley closed T6996: Write an `--output <file>` mode for `storage dump` which can gzip, a subtask of T10758: Make `bin/storage dump` replica-aware, as Resolved.
Dec 13 2016, 11:38 AM · Restricted Project
epriestley added a comment to T11971: Build an Icon Typeahead.

(I renamed the "Up for Grabs" column to "Ready", and kicked this out since it doesn't have detailed technical instructions that a new contributor could follow like the other tasks in that column do.)

Dec 13 2016, 11:36 AM · PHUI
epriestley moved T11971: Build an Icon Typeahead from Ready to Backlog on the Contributor Onboarding board.
Dec 13 2016, 11:35 AM · PHUI
epriestley added a comment to T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in.

Can you browse to https://your.install.com/applications/view/PhabricatorFilesApplication/ and post a screenshot of the "Storage Engines" panel on that page? It should look a little bit like this (example from this install), although your settings are presumably different:

Dec 13 2016, 11:32 AM · Files, Documentation, Bug Report

Dec 12 2016

epriestley closed T4945: Subscribing users when they award tokens as Wontfix.

This doesn't seem to be going anywhere too fast so I'm just going to nuke it while I'm combing through old things rather than letting it collect dust forever.

Dec 12 2016, 11:36 PM · Tokens
lewellyn awarded T11989: Wage an endless war against HP Printer Fax Support a The World Burns token.
Dec 12 2016, 11:20 PM · Abuse
chad awarded T11989: Wage an endless war against HP Printer Fax Support a Evil Spooky Haunted Tree token.
Dec 12 2016, 11:16 PM · Abuse
epriestley updated subscribers of T11989: Wage an endless war against HP Printer Fax Support.

We scored our first kill today. @dgdfgdg slipped through our defenses in his initial volley, but we reacted quickly and the system automatically deflected his second salvo.

Dec 12 2016, 11:14 PM · Abuse
epriestley closed T4883: Customizing the default homepage for all users as Resolved.

T11957 is the modern followup for this.

Dec 12 2016, 10:38 PM · Dashboards (v2)
epriestley closed T4850: Defining policies for "Project Members" as Resolved.

At least in this use case, I believe things turned out alright without this policy.

Dec 12 2016, 10:34 PM · Restricted Project, Policy
epriestley closed T4806: Give installs more control over session expiry / prompt for reauth before taking security actions as Wontfix.

It's critical that we are addressing specific, plausible threat scenarios when implementing security protocols. This task currently lacks such a scenario.

Dec 12 2016, 10:20 PM · Restricted Project, Auth
epriestley closed T4448: Support symlinking phriction pages as Invalid.

This is pretty old and doesn't meet the requirements of a modern feature request (notably, clear definition of a root problem). Feel free to file a new request if this is still an issue. Particularly helpful would be discussion of why editing the page to say "Go see <other page>" is insufficient.

Dec 12 2016, 9:47 PM · Restricted Project, Phriction
epriestley closed T4439: Set up SPF records for domains we control as Resolved.

This got done at some point, I believe, since we have an SPF record now.

Dec 12 2016, 9:44 PM · Security, Mail
epriestley closed T3583: Fix the Swamp of Suck that is the home page content panel as Resolved.
  • Over time, we've drained the swamp to some degree on the default home page, by moving toward more useful defaults.
  • We implemented Dashboards. Although we'd like to improve them, they've allowed ambitious users to fix this themselves for some time.
  • See T11957 and M1473 for modern followups with a more concrete plan to lay this to rest.
  • See also T11132 for discussion of NUX-oriented changes, specifically.
Dec 12 2016, 9:30 PM · Restricted Project, Dashboards (v2)
epriestley closed T3583: Fix the Swamp of Suck that is the home page content panel, a subtask of T3979: Support logged out version of the home page, as Resolved.
Dec 12 2016, 9:30 PM · Phabricator
epriestley closed T3583: Fix the Swamp of Suck that is the home page content panel, a subtask of T4323: Scaling bug (for Chrome browser), as Resolved.
Dec 12 2016, 9:29 PM · Design, Badge Awarded
epriestley closed T2683: Improve the performance of Diffusion browse views as Resolved.

This is a billion years old now -- see, e.g., T11954 for more modern work.

Dec 12 2016, 9:21 PM · Diffusion
epriestley closed T2542: Provide a link from revisions that are blamees to their blamers as Resolved.

"Blame Revision" was a freeform text field at Facebook (from before DiffCamp, even) where you were ideally supposed to enter the revision or commit that introduced the bug you're fixing, if you were fixing a bug introduced by some known change.

Dec 12 2016, 9:18 PM · Diffusion, Audit, Differential
epriestley closed T2542: Provide a link from revisions that are blamees to their blamers, a subtask of T1751: Consider ways to improve revert handling, as Resolved.
Dec 12 2016, 9:18 PM · Restricted Project, Differential, Diffusion
epriestley added a project to T2115: Back button support in Lightbox: Quicksand.
Dec 12 2016, 9:10 PM · Quicksand, Lightbox, Files
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

That Chrome change seems at least plausible as a root cause to me, but I definitely don't know enough about the Chrome internals to really hazard a guess.

Dec 12 2016, 6:46 PM · Bug Report
epriestley closed T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden as Resolved by committing Restricted Diffusion Commit.
Dec 12 2016, 6:39 PM · Bug Report
epriestley added a revision to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden: Restricted Differential Revision.
Dec 12 2016, 6:36 PM · Bug Report
epriestley closed T11999: Fatal on "Customize Menu..." on home as Resolved by committing Restricted Diffusion Commit.
Dec 12 2016, 6:33 PM · Bug Report
epriestley renamed T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden from Chrome 55 no longer scrolls to elements which are completely hidden to When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.
Dec 12 2016, 6:16 PM · Bug Report
epriestley added a revision to T11999: Fatal on "Customize Menu..." on home: Unknown Object (Differential Revision).
Dec 12 2016, 6:16 PM · Bug Report
epriestley renamed T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden from Links to Task's messages don't scroll to the message on Chrome 55 to Chrome 55 no longer scrolls to elements which are completely hidden.
Dec 12 2016, 6:16 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

See also https://code.google.com/p/chromium/issues/detail?id=473657 for earlier adventures in Chrome.

Dec 12 2016, 6:13 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Here's my upstream report:

Dec 12 2016, 6:11 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Here's my reduced test case for Chome 55:

Dec 12 2016, 5:55 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Oh, it reproduces for me.

Dec 12 2016, 5:31 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

This appears to be a bug in Chrome, because this fixes it:

Dec 12 2016, 5:31 PM · Bug Report
epriestley added a comment to T11998: Content flashes when loading pages in Chrome.

Specifically, I resolved it by just pushing everything.

Dec 12 2016, 5:06 PM
epriestley closed T11998: Content flashes when loading pages in Chrome as Resolved.

I think I had pushed new code to secure001 and then wandered off to do something else.

Dec 12 2016, 5:05 PM
epriestley updated subscribers of T11998: Content flashes when loading pages in Chrome.
Dec 12 2016, 11:43 AM
epriestley created T11998: Content flashes when loading pages in Chrome.
Dec 12 2016, 11:43 AM

Dec 11 2016

epriestley renamed T11957: Add MenuEngine to Home from Add PanelEngine to Dashboards to Add MenuEngine to Dashboards.
Dec 11 2016, 9:29 PM · Profile Menu Item, Dashboards
epriestley closed T11521: Request Review action should clear "accepted older" status as Resolved.

Oh, I think the edit to the title here is actually misleading, and the author in this scenario never used "Request Review" (this action is only available if the author has previously used "Plan Changes", which they did not appear to in this scenario).

Dec 11 2016, 9:06 PM · Restricted Project, Differential, Bug Report
epriestley added a comment to T11989: Wage an endless war against HP Printer Fax Support.

I have a not-so-bad version of this in mind but it seems that the printer faxers are too terrified of our advanced defenses to even attack us any more.

Dec 11 2016, 8:41 PM · Abuse
epriestley added a revision to T11957: Add MenuEngine to Home: Unknown Object (Differential Revision).
Dec 11 2016, 6:54 PM · Profile Menu Item, Dashboards
epriestley added a revision to T11957: Add MenuEngine to Home: Unknown Object (Differential Revision).
Dec 11 2016, 5:51 PM · Profile Menu Item, Dashboards
epriestley added a revision to T11957: Add MenuEngine to Home: Unknown Object (Differential Revision).
Dec 11 2016, 5:08 PM · Profile Menu Item, Dashboards
epriestley added a revision to T11957: Add MenuEngine to Home: Unknown Object (Differential Revision).
Dec 11 2016, 5:03 PM · Profile Menu Item, Dashboards
epriestley closed T11980: Links to external systems as Wontfix.
  • Systems integrated with Doorkeeper (JIRA, Asana, some prototype GitHub support) already get URIs marked up.
  • The current JIRA integration does cover JIRA URIs in all remarkup systems, including Phriction and Maniphest, although you can not link to multiple JIRA installs until T6703, and you must use full URIs (if you use JIRA-123, it's possible that multiple linked installs have project namespaces called "JIRA"). It's possible we'll support this more naturally in the future, but not until after T6703, which is a very low priority.
  • Custom markup rules already supported (see P1157, P1209 for some examples), although you're on your own to write them. These are probably the best fit for your use case.
  • I believe needs for this sort of thing are often very specialized, so I do not currently plan to add any kind of generic, configurable remarkup rule that just matches arbitrary regexps against stuff and links them. You could write such a rule as an extension. One caveat to this is that we currently have bugtraq.url and bugtraq.logregex, which sort of work like this, except in a bad way. I'd like to remove them in the future, but there's an outside possibility that we'll replace them with a more flexible system like the one you describe.
Dec 11 2016, 4:56 PM · Remarkup, Feature Request
epriestley closed T11995: Fatal error while saving global default preferences as Resolved by committing Restricted Diffusion Commit.
Dec 11 2016, 4:28 PM · User Preferences, Bug Report
epriestley closed T11993: New install errors out before "run storage upgrade" message as Resolved by committing Restricted Diffusion Commit.
Dec 11 2016, 4:28 PM · Bug Report, Installing & Upgrading
epriestley added a comment to T11993: New install errors out before "run storage upgrade" message.

Thanks!

Dec 11 2016, 3:19 PM · Bug Report, Installing & Upgrading
epriestley claimed T11993: New install errors out before "run storage upgrade" message.
Dec 11 2016, 3:19 PM · Bug Report, Installing & Upgrading
epriestley added a comment to T11995: Fatal error while saving global default preferences.

Thanks! Yeah, this was just some editing/testing slop on my part. Your suggested fix is correct.

Dec 11 2016, 3:19 PM · User Preferences, Bug Report
epriestley claimed T11995: Fatal error while saving global default preferences.
Dec 11 2016, 3:19 PM · User Preferences, Bug Report
epriestley closed T11994: 'Affected files' doesn't work in 'Commits' Herald rules as Resolved.
Dec 11 2016, 3:18 PM · Bug Report (Needs Information)
epriestley added a revision to T11993: New install errors out before "run storage upgrade" message: Unknown Object (Differential Revision).
Dec 11 2016, 3:17 PM · Bug Report, Installing & Upgrading
epriestley added a revision to T11995: Fatal error while saving global default preferences: Unknown Object (Differential Revision).
Dec 11 2016, 3:17 PM · User Preferences, Bug Report
Info-Screen awarded Blog Post: Write, Review, Merge, Publish: Phabricator Review Workflow a Like token.
Dec 11 2016, 12:45 PM