Page MenuHomePhabricator
Create Task
Maniphest T2115

Back button support in Lightbox
Open, NormalPublic
Actions

Description

A lot of times now, I've clicked on an image to bring up the lightbox, then habitually hit the back button on my mouse to get out of it.
I think I'm used to how Facebook handles this -- if you hit the back button in the lightbox on Facebook, it simply closes the lightbox. On Phabricator, it takes me back an entire page.

I think Facebook implements this with the HTML 5 history API (but I could be wrong here - I'm not sure how else it would be done, but I'm sure there are other ways, and I haven't looked into it).

Would it be reasonable to explore using that here? I guess this sort of deps on T2086 if we do use the history API?

Related Objects
Search...

StatusAssignedTask
 OpenNoneT2115 Back button support in Lightbox
Restricted Maniphest Task

Event Timeline

codeblock triaged this task as Normal priority.Nov 25 2012, 2:22 PM
codeblock added a project: Phabricator.
codeblock added subscribers: codeblock, epriestley.
codeblock edited this Maniphest Task.Nov 25 2012, 2:23 PM
epriestley added a comment.Nov 27 2012, 8:58 PM

This is reasonable and correctly dep'd on T2086 -- major technical hurdle is that we first-class URIs for the lightboxes to do this properly (i.e., when you copy/paste whatever's in the URL bar it should theoretically pop the right image up in a lightbox...)

chad added a subscriber: chad.Dec 31 2012, 1:20 AM
chad edited projects, added Files; removed Phabricator.Dec 24 2014, 7:27 AM
avivey changed the visibility from "All Users" to "Public (No Login Required)".Feb 17 2016, 1:04 AM
chad added a project: Lightbox.Nov 18 2016, 6:07 PM
Herald added a subscriber: eadler. · View Herald TranscriptNov 18 2016, 6:07 PM
epriestley added a project: Quicksand.Dec 12 2016, 9:10 PM
avivey awarded a token.Dec 12 2016, 9:16 PM
Phabricator · Built by Phacility