Page MenuHomePhabricator

Locations Scenario: Fix a Typo
Closed, ResolvedPublic

Description

A clumsy developer has misspelled "Locations" as "Locartions"! This is visible in the breadcrumbs at the top of the page at: http://your.install.com/locations/

The major goal of this task is to familiarize you with the Phabricator review workflow. To start with, create a local feature branch:

$ git checkout -b typofix

Now:

  • Use grep or git grep to find the misspelling in the codebase.
  • Correct it.
  • Test that the UI now spells the word correctly.

Once your change looks good, submit it for review like this:

$ git add .
$ git commit -m 'Fix locartions typo'
$ arc diff

This will prompt you to set up credentials at first, but once you do that it will bring up an editor so you can provide more details about the change:

  • The first line should have a one-line title for the commit.
  • In Summary, write Fixes T12004. so this task will be closed when the change lands. You can optionally provide additional summary text (usually, about why you are making a particular change).
  • In Test Plan, describe what you did to make sure your change actually fixes the problem.
  • In Reviewers, write epriestley.

Save the file and arc should create a new revision (Dxxxx). I'll review it, then (hopefully) approve it. Once it is approved, publish the change like this:

$ arc land

That will merge and push the change, and close this task as a side effect.