Page MenuHomePhabricator
Feed Advanced Search

Aug 9 2016

epriestley added a comment to T11453: Increase storage size of "summary" column on DiffusionRepositoryCommit.

We truncate these summaries at 80 bytes because the underlying storage column is text80, which is only 80 bytes long when represented using binary collation in older MySQL without utf8mb4 support. We can not store more text in the general case without changing this column size.

Aug 9 2016, 8:12 PM · Diffusion, Bug Report
saggid added a project to T11453: Increase storage size of "summary" column on DiffusionRepositoryCommit: Diffusion.
Aug 9 2016, 7:52 PM · Diffusion, Bug Report
venky added a comment to T11411: Commits to github branch close Differential revision.

The other thing that was confusing was that "Config" didn't actually have all the settings -- some settings are in Config, some user settings are in my "profile", some other settings are in individual apps. It would help to consolidate these into one directory.

Aug 9 2016, 5:12 PM · Documentation, Diffusion
isfs added a comment to T11267: Commit graph broken for Mercurial repositories.

I was experiencing this problem too and it works in current stable for me now.

Aug 9 2016, 2:14 AM · Diffusion, Bug Report

Aug 8 2016

avivey added a subtask for T9287: Working with many repositories: T7773: Allow code reviews across multiple repos.
Aug 8 2016, 4:06 PM · Restricted Project, Restricted Project, Diffusion

Aug 7 2016

eadler added a project to T6008: Editing files and contributing changes via web: Restricted Project.
Aug 7 2016, 8:10 PM · Restricted Project, Wikimedia, Diffusion, Differential

Aug 5 2016

eadler added a project to T3788: Improve encoding management in Diffusion: Restricted Project.
Aug 5 2016, 5:24 PM · Restricted Project, Diffusion
eadler added a project to T8476: Rename `phabricator_repository` database: Restricted Project.
Aug 5 2016, 5:24 PM · Restricted Project, Database, Diffusion
eadler added a project to T1602: Support scoped symbols: Restricted Project.
Aug 5 2016, 5:24 PM · Restricted Project, Symbols, Diffusion, Differential
eadler added a project to T11208: Support Subversion revprops: Restricted Project.
Aug 5 2016, 5:24 PM · Restricted Project, Subversion, Diffusion
eadler added a project to T10604: Allow application code to stream request data: Restricted Project.
Aug 5 2016, 5:24 PM · Diffusion (v3), Restricted Project
eadler added a project to T9915: Audit Changes TOC fail redirecting to right subdirectory when clicking on fa-folder-open icon and produces an unhandled exception: Restricted Project.
Aug 5 2016, 5:05 PM · Restricted Project, Diffusion, Bug Report
eadler added a project to T10053: On branches, show buildable status of their commits; allow branches to be queried on: Restricted Project.
Aug 5 2016, 4:52 PM · Restricted Project, Diffusion, Harbormaster
eadler added a project to T10568: Report partially failed builds better in Diffusion history: Restricted Project.
Aug 5 2016, 4:45 PM · Restricted Project, Harbormaster, Diffusion, Feature Request
eadler added a project to T10093: When builds fail because the staging area was not pushed, make the cause clear: Restricted Project.
Aug 5 2016, 4:44 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request

Aug 4 2016

clemvangelis added a comment to T10893: repo update fails for repos with 1000s of closing branches.

I actually encouter the same problem. Setting autoclose on master only fixed it.

Aug 4 2016, 3:29 PM · Diffusion, Bug Report
epriestley added a comment to T11391: Unable to add uri to Diffusion.

Update past rPa5b26104 (Jul 9).

Aug 4 2016, 2:51 PM · Bug Report (Needs Information), Diffusion
• marfago added a comment to T11391: Unable to add uri to Diffusion.

Sorry I missed the previous notification.

Aug 4 2016, 2:48 PM · Bug Report (Needs Information), Diffusion
epriestley closed T11391: Unable to add uri to Diffusion as Invalid.

Closing this since we haven't seen a response for about a week, this report didn't follow the instructions by omitting version information, and it's very likely that this is resolved by updating.

Aug 4 2016, 2:40 PM · Bug Report (Needs Information), Diffusion

Aug 2 2016

epriestley closed T11403: Phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail.. as Resolved.

If you can identify why sudo was broken and what you did to fix it, we can probably add a setup warning to test for this problem. However, since we haven't seen other users with broken sudo and we couldn't help users resolve the issue with available information even if we did detect it, I don't think pursuing a check in the upstream is worthwhile.

Aug 2 2016, 6:18 PM · Diffusion, Bug Report
chad edited projects for T11411: Commits to github branch close Differential revision, added: Diffusion, Documentation; removed Bug Report.
Aug 2 2016, 4:50 PM · Documentation, Diffusion
chad added projects to T11407: Make is possible to react to commits being parsed: Diffusion, Herald.
Aug 2 2016, 4:49 PM · Herald, Diffusion, Feature Request
chad added a project to T11403: Phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail..: Diffusion.

Sounds like this is resolved? Or should we attempt to catch this case?

Aug 2 2016, 4:49 PM · Diffusion, Bug Report

Jul 31 2016

epriestley added a comment to T6273: Inline comments do not support editing (Pholio, Differential, Diffusion).

See also T11401, although this started life as a Pholio task and that's now a code-specific UI task so I don't know if they're actually the same.

Jul 31 2016, 7:08 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley added a comment to T2495: Improve whitespace expansion of tab literals.

See Planning for help understanding timelines and priorities.

Jul 31 2016, 12:31 PM · Restricted Project, FreeBSD, Diffusion, Differential
william.pursell added a comment to T2495: Improve whitespace expansion of tab literals.

Is this still actively being worked on, is there a different solution than View Options->Set Tab Width, or should I apply the patch referenced by raman.rathod?

Jul 31 2016, 11:34 AM · Restricted Project, FreeBSD, Diffusion, Differential

Jul 29 2016

eadler edited projects for T11391: Unable to add uri to Diffusion, added: Diffusion, Bug Report (Needs Information); removed Bug Report.
Jul 29 2016, 4:16 PM · Bug Report (Needs Information), Diffusion

Jul 24 2016

rabahmeradi added a comment to T5463: Could not stat AuthorizedKeysCommand .

I ran into the same issue and phabricator-ssh-hook.sh and its parent directory are owned by root and the script have 755 mode. The script was in /root/phabricator/ and vcs-user doesn't have access to that directory (because the /root directory is not accessible). I put the script in /etc/phabricator and it worked.

Jul 24 2016, 2:39 PM · Diffusion

Jul 21 2016

epriestley moved T10945: Replace "repository.query" with "diffusion.repository.search" in Arcanist from vMajor to API Changes on the Arcanist board.
Jul 21 2016, 11:55 AM · Restricted Project, Conduit, Arcanist, Diffusion
epriestley renamed T9713: In Diffusion, show commit messages as parsed fields by default with an option to view them raw from Arcanist commit messages format usernames without a leading "@" to In Diffusion, show commit messages as parsed fields by default with an option to view them raw.
Jul 21 2016, 11:47 AM · Diffusion (v3)
epriestley moved T10945: Replace "repository.query" with "diffusion.repository.search" in Arcanist from Backlog to vMajor on the Arcanist board.
Jul 21 2016, 11:45 AM · Restricted Project, Conduit, Arcanist, Diffusion

Jul 18 2016

• sshannin updated Q444: Associate old commits with new phabricator user from to Associate old commits with new phabricator user.
Jul 18 2016, 7:18 PM · Diffusion

Jul 16 2016

epriestley closed T7047: Add user preference for diffs in emails as Wontfix.

Per T7047#180833, no idea what the use case is for per-user/per-Herald/per-Mail.

Jul 16 2016, 2:09 PM · Restricted Project, Differential, Mail, Diffusion

Jul 15 2016

avivey added a comment to T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs.

T11335 talks about a hosting system (gitblit) that adds meta-data to refs/meta/ refs, which show up in phabricator as real commits.

Jul 15 2016, 8:29 PM · Diffusion (v3), Restricted Project, Mail, Haskell.org, Bug Report
avivey merged T11335: Undesirable 'push' commits in feed into T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs.
Jul 15 2016, 6:26 PM · Diffusion (v3), Restricted Project, Mail, Haskell.org, Bug Report

Jul 14 2016

michal.fuca.fucik added a comment to T5132: Document the special syntax you can use in commit messages to cause effects.

Hey guys, where should I hook my custom parser if I need to add any additional behaviour on 'CodeReviewed' keyword in commit message due to parsing from repository?
Actually I need to mark commit as audited when commit message contains previously specified string.

Jul 14 2016, 10:13 AM · Guides, Diffusion

Jul 13 2016

thoughtpolice added a comment to T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs.

Thanks for listening to my hair-brained schemes. Yeah, the motivation is totally clear to me FWIW, and thinking about it more, I strongly suggest this is related to T9161.

Jul 13 2016, 8:53 PM · Diffusion (v3), Restricted Project, Mail, Haskell.org, Bug Report
20after4 added a comment to T10155: Error when displaying a repository with only one empty commit.

Needs a check for empty and at least a better error message in DiffusionBrowseQueryConduitAPIMethod.php:115

Jul 13 2016, 1:35 PM · Diffusion, Bug Report
20after4 added a comment to T10155: Error when displaying a repository with only one empty commit.

We are seeing this as well when attempting to browse an empty commit: https://phabricator.wikimedia.org/T140236

Jul 13 2016, 1:32 PM · Diffusion, Bug Report

Jul 12 2016

avivey moved T7701: Surface Code/File search better in Diffusion from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 12 2016, 9:55 PM · Restricted Project, Design, Diffusion
avivey moved T5698: Github-style Remarkup previews on a checked-in resource from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 12 2016, 9:55 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
avivey moved T929: Allow two arbitrary revisions to be compared in Diffusion from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 12 2016, 9:55 PM · Diffusion (v3), Restricted Project
epriestley added a comment to T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs.

We could also possibly just drop these commit mails in all cases where no audit triggered. It's easy to write a Herald rule to restore them if you do want them. Possibly involved enough to be adjacent to T10978, though.

Jul 12 2016, 2:07 PM · Diffusion (v3), Restricted Project, Mail, Haskell.org, Bug Report
epriestley added a comment to T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs.

A small part of the motivation for this change was to make commits reachable only from Gerrit magic refs (refs/changes/..., similar to refs/pull/...) visible in Diffusion. This didn't really make it into a single upstream task I think, but some of this is scattered across T9726 / T6878. So we have at least one use case where users want these refs to exist and be treated roughly like they were tags/branches.

Jul 12 2016, 2:00 PM · Diffusion (v3), Restricted Project, Mail, Haskell.org, Bug Report
thoughtpolice added projects to T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs: Diffusion, Mail.
Jul 12 2016, 1:49 AM · Diffusion (v3), Restricted Project, Mail, Haskell.org, Bug Report

Jul 10 2016

epriestley added a comment to T10423: Huge diffs (>8MB) should stream directly into file storage in Diffusion when downloaded.

I deployed that stuff to the affected shard and things look OK now. The original issue described in this task wasn't affected.

Jul 10 2016, 3:16 PM · Phacility, Files, Diffusion, Bug Report
epriestley added a comment to T10423: Huge diffs (>8MB) should stream directly into file storage in Diffusion when downloaded.

This didn't really end up being related to the other issue here (streaming huge diffs into Files) but it's a little late for me to split it out now.

Jul 10 2016, 2:32 PM · Phacility, Files, Diffusion, Bug Report
epriestley added a revision to T10423: Huge diffs (>8MB) should stream directly into file storage in Diffusion when downloaded: Restricted Differential Revision.
Jul 10 2016, 2:29 PM · Phacility, Files, Diffusion, Bug Report
epriestley added a comment to T10423: Huge diffs (>8MB) should stream directly into file storage in Diffusion when downloaded.

This is largely the result of --find-copies-harder being explosively slow for large result sets in large repositories. With this flag, the runtime rises from <1s to >3m, at which point git itself bails out:

Jul 10 2016, 2:15 PM · Phacility, Files, Diffusion, Bug Report
epriestley added a comment to T10423: Huge diffs (>8MB) should stream directly into file storage in Diffusion when downloaded.

This is actually happening on the cluster/daemon pathway so it's not really related to the original issue here. However, the daemon client is timing out:

Jul 10 2016, 2:01 PM · Phacility, Files, Diffusion, Bug Report
epriestley added a comment to T10423: Huge diffs (>8MB) should stream directly into file storage in Diffusion when downloaded.

I suspended the instance in question since it was a test instance, and continuing to generate web requests for the 5M-line diff and disrupt other processes on the shard.

Jul 10 2016, 1:57 PM · Phacility, Files, Diffusion, Bug Report
epriestley added a comment to T10423: Huge diffs (>8MB) should stream directly into file storage in Diffusion when downloaded.

We had a shard disruption in the cluster this morning that I don't have a clear smoking gun on, but one issue that looks questionable is on this pathway -- I see several requests to generate diffs of an extremely large (5M line) commit coming from the web.

Jul 10 2016, 1:31 PM · Phacility, Files, Diffusion, Bug Report
epriestley raised the priority of T10423: Huge diffs (>8MB) should stream directly into file storage in Diffusion when downloaded from Wishlist to High.
Jul 10 2016, 1:26 PM · Phacility, Files, Diffusion, Bug Report

Jul 9 2016

chad closed T8149: Repository search alignment issue as Resolved.

Doesn't reproduce in any mobile browser (Safari, Chrome) I have access to. Presume resolved, but if still occurring please re-open with full reproduction steps.

Jul 9 2016, 6:18 PM · Mobile, Diffusion

Jul 8 2016

epriestley closed T11278: It's confusing to figure out in the UI how to import a repository now as Resolved by committing Restricted Diffusion Commit.
Jul 8 2016, 2:43 PM · Design, Diffusion
epriestley added a revision to T11278: It's confusing to figure out in the UI how to import a repository now: Restricted Differential Revision.
Jul 8 2016, 12:50 PM · Design, Diffusion
epriestley closed T11157: ability to disable support for certain VCS as Invalid.

This is purely hypothetical and it's hard for me to imagine users getting it wrong by accident.

Jul 8 2016, 12:24 PM · Diffusion, Feature Request
chad added a comment to T11269: Repository update command fails on empty Git repositories.

I can't think of any reason it would ask that unless something changed locally. If you have no local changes to phabricator/, just reset to HEAD.

Jul 8 2016, 4:31 AM · Diffusion, Bug Report
• minishine added a comment to T11269: Repository update command fails on empty Git repositories.

@chad I don't know, I installed phabricator under the direction of doc and then resolved some setup Issues.

Jul 8 2016, 3:22 AM · Diffusion, Bug Report

Jul 7 2016

eadler added a project to T1751: Consider ways to improve revert handling: Restricted Project.
Jul 7 2016, 5:10 PM · Restricted Project, Diffusion, Differential
eadler added a project to T6273: Inline comments do not support editing (Pholio, Differential, Diffusion): Restricted Project.
Jul 7 2016, 5:00 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
• vanblaze added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

You are right, it does not specifically describe or refer to an import button anywhere.

Jul 7 2016, 3:28 PM · Design, Diffusion
epriestley added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

Okay, but the docs don't actually describe or refer to an import button anywhere -- there's no text like "click the import button" that I missed when updating things?

Jul 7 2016, 2:58 PM · Design, Diffusion
• vanblaze added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

Another issue is that when following the user docs, the docs still points towards having the import button on the creation of project.

I can't find where we say this in the documentation. Can you point me at what you're seeing?

Jul 7 2016, 2:44 PM · Design, Diffusion
chad added a comment to T11269: Repository update command fails on empty Git repositories.

Why do you have local changes in your phabricator folder?

Jul 7 2016, 1:52 PM · Diffusion, Bug Report
• minishine added a comment to T11269: Repository update command fails on empty Git repositories.

Sorry to trouble you @epriestley , I have the same question(T11273) . After your committing rP5ffdb732735c, I tried to update my phabricator under the direction of doc(https://secure.phabricator.com/book/phabricator/article/upgrading/). While I executed git pull,the terminal shows

屏幕快照 2016-07-07 15.45.45.png (262×1 px, 61 KB)
. So should I commit local changes or checkout them?

Jul 7 2016, 7:49 AM · Diffusion, Bug Report

Jul 6 2016

epriestley added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

Another issue is that when following the user docs, the docs still points towards having the import button on the creation of project.

Jul 6 2016, 11:31 PM · Design, Diffusion
epriestley added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

I'm leaning toward just adding a big "Clippy" element to this UI:

Jul 6 2016, 11:30 PM · Design, Diffusion
chad added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

I think if you haven't activated the repository and visit URIs, we can show an "Import" type note and call it a day for now.

Jul 6 2016, 10:55 PM · Design, Diffusion
chad added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

Yeah, I think it goes away after you push "activate"

Jul 6 2016, 10:54 PM · Design, Diffusion
cspeckmim added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

Is that text already present and I just missed it?

Jul 6 2016, 10:48 PM · Design, Diffusion
chad added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

We can probably start with a text hint on this view:

Jul 6 2016, 10:44 PM · Design, Diffusion
• vanblaze added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

Another issue is that when following the user docs, the docs still points towards having the import button on the creation of project. I was pretty confused as it clearly wasn't that. Perhaps the page after clicking the 'Create Repository' could have an option of importing, which presets the values to observe a repo.

Jul 6 2016, 10:37 PM · Design, Diffusion
cspeckmim added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

I was confused at first - from previous workflow I thought I took a wrong step when setting up the repository and landed on a "completed" repository page which I didn't expect without selecting host vs. mirror. I deleted the repository and started again and finally got it after hours of turmoil (maybe more like a minute of prodding).

Jul 6 2016, 10:22 PM · Design, Diffusion
chad added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

yeah doesn't import ssh from what I see and they just say to use the command-line importer if you can't use the web tool

Jul 6 2016, 2:32 AM · Design, Diffusion
epriestley added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

Here's what I see -- step 1:

Jul 6 2016, 2:28 AM · Design, Diffusion
isfs added a revision to T10920: Allow assigning a diff to a commit post-facto: Restricted Differential Revision.
Jul 6 2016, 2:11 AM · Diffusion, Feature Request
chad added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

I get this screen:

Jul 6 2016, 2:10 AM · Design, Diffusion
epriestley added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

GitHub's import doesn't seem to work with any repositories that require credentials?

Jul 6 2016, 2:04 AM · Design, Diffusion
epriestley added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

Oh, I was looking at this:

Jul 6 2016, 2:01 AM · Design, Diffusion
chad added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

pasted_file (534×590 px, 62 KB)

Jul 6 2016, 2:01 AM · Design, Diffusion
chad added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

pasted_file (159×286 px, 11 KB)

Jul 6 2016, 2:00 AM · Design, Diffusion
epriestley added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

GitHub make this reasonably obvious.

Jul 6 2016, 1:59 AM · Design, Diffusion
chad added a comment to T11278: It's confusing to figure out in the UI how to import a repository now.

People keep getting stuck on this, so we should look at fixing the UI so we don't have to post the documentation over and over.

Jul 6 2016, 1:52 AM · Design, Diffusion
chad renamed T11278: It's confusing to figure out in the UI how to import a repository now from Can no longer find 'import from existing repository' to It's confusing to figure out in the UI how to import a repository now.
Jul 6 2016, 1:51 AM · Design, Diffusion

Jul 5 2016

epriestley added a comment to T11269: Repository update command fails on empty Git repositories.

Thanks for the report! I believe this should now be resolved in HEAD of master.

Jul 5 2016, 4:10 PM · Diffusion, Bug Report
epriestley closed T11269: Repository update command fails on empty Git repositories as Resolved by committing Restricted Diffusion Commit.
Jul 5 2016, 4:09 PM · Diffusion, Bug Report
epriestley closed T10920: Allow assigning a diff to a commit post-facto as Resolved.

Yes, commit/revision and commit/task relationships can now be managed manually from the web UI.

Jul 5 2016, 3:52 PM · Diffusion, Feature Request
nochum added a comment to T10920: Allow assigning a diff to a commit post-facto.

I'm pretty sure this is fixed now with the Edit Related Objects menu awesomeness! Thanks.

Jul 5 2016, 3:32 PM · Diffusion, Feature Request
epriestley added a revision to T11269: Repository update command fails on empty Git repositories: Restricted Differential Revision.
Jul 5 2016, 3:30 PM · Diffusion, Bug Report
epriestley claimed T11269: Repository update command fails on empty Git repositories.
Jul 5 2016, 3:26 PM · Diffusion, Bug Report
epriestley merged T11273: Update error while Repository Updates into T11269: Repository update command fails on empty Git repositories.
Jul 5 2016, 3:26 PM · Diffusion, Bug Report
lucaro added a comment to T11267: Commit graph broken for Mercurial repositories.

Thanks for the quick response. I'll let you know as soon as the change gets merged into stable.

Jul 5 2016, 6:54 AM · Diffusion, Bug Report

Jul 4 2016

eadler moved T10619: Permit custom harbormaster actions from the diffusion/differential pages from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:19 PM · Restricted Project, Diffusion, Differential, Harbormaster, Feature Request
eadler moved T10767: fold empty directories in Browse view from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:18 PM · Restricted Project, Diffusion, Feature Request
eadler moved T6024: Display (post-push) audit-state in Diffusion commit-list from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:18 PM · Restricted Project, Audit, Diffusion
eadler moved T4369: Phabricator HTTP repository hosting has fairly severe scalability limits from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:18 PM · Diffusion (v3), Restricted Project
eadler moved T8238: Formally support side-band change handoff in external repositories from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:18 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
eadler moved T9210: break apart Publish/Notify repo setting from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:16 PM · Restricted Project, Restricted Project, Diffusion
eadler moved T1621: In Git, clean up local tags that are no longer present in the remote from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 4 2016, 9:16 PM · Restricted Project, Diffusion