Page MenuHomePhabricator
Feed Advanced Search

Dec 10 2015

epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

Wording on this feed story isn't quite right, not sure if that's new or not:

Dec 10 2015, 9:04 PM · ApplicationEditor
epriestley created T9952: Let "Land Revision" target branches other than master.
Dec 10 2015, 8:45 PM · Differential
epriestley reopened T9952: Let "Land Revision" target branches other than master, a subtask of T182: Commit into repository directly from differential, as Open.
Dec 10 2015, 8:45 PM · Haskell.org, Restricted Project, Differential
epriestley moved T9950: Provide a URL that indicates Harbormaster build status as an image from Backlog to Far Future on the Harbormaster board.
Dec 10 2015, 8:21 PM · Restricted Project, Harbormaster, Feature Request
epriestley triaged T9950: Provide a URL that indicates Harbormaster build status as an image as Wishlist priority.
Dec 10 2015, 8:21 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T9936: During arc land harbormaster failure, cannot tell if "arc lint" or "arc unit" failed.

@angie, I added you to Community so you should have sweeping powers on this install now.

Dec 10 2015, 6:54 PM · Harbormaster, Arcanist, Restricted Project, Bug Report
epriestley added a member for Community: angie.
Dec 10 2015, 6:54 PM
epriestley added a comment to T9944: Figure out what happens when you archive a badge.

"Close" makes sense to me. And, yeah, I agree that long-term some kind of "All Badges" link that leads to, like:

Dec 10 2015, 6:36 PM · Badges
epriestley added a comment to T9944: Figure out what happens when you archive a badge.

If you know you had three badges yesterday and then visit your profile and see only two badges, there's no way to figure out what happened (without examining the edit history of every badge), if we completely hide them, is there?

Dec 10 2015, 6:18 PM · Badges
aklapper awarded T4768: Phabricator silently overwrites concurrent changes (no conflict detection) a Love token.
Dec 10 2015, 4:18 PM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
epriestley added a project to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads: Mercurial.
Dec 10 2015, 3:39 PM · Mercurial, Arcanist
epriestley moved T8075: arc patch fails on Windows with SVN (because it uses "cd", not "setCWD") from Backlog to arc patch on the Arcanist board.
Dec 10 2015, 3:06 PM · Windows, Arcanist
epriestley moved T8307: `arc patch` applies diffs from another repository from Backlog to arc patch on the Arcanist board.
Dec 10 2015, 3:06 PM · Arcanist
epriestley moved T3277: `arc cleanup` to cleanup branches used by `arc patch` from Backlog to arc patch on the Arcanist board.
Dec 10 2015, 3:06 PM · Arcanist
epriestley moved T2371: Examine the interaction between --nobranch and --nocommit from Backlog to arc patch on the Arcanist board.
Dec 10 2015, 3:05 PM · Arcanist
epriestley moved T1781: `arc patch` doesn't work on revisions committed to different path from Backlog to arc patch on the Arcanist board.
Dec 10 2015, 3:04 PM · Arcanist
epriestley moved T1986: arc patch support for -p from unix patch from Backlog to arc patch on the Arcanist board.
Dec 10 2015, 3:04 PM · Arcanist
epriestley closed T9945: Unable to delete owner packages, it does not implement PhabricatorDestructibleInterface as Resolved by committing Restricted Diffusion Commit.
Dec 10 2015, 3:04 PM · Owners, Bug Report
epriestley moved T9044: arc diff eagerly detects git-svn repo, which makes arc-patch hang from Backlog to arc patch on the Arcanist board.
Dec 10 2015, 3:03 PM · Restricted Project, Arcanist
epriestley moved T9069: arc patch can't handle binary file correctly from Backlog to arc patch on the Arcanist board.
Dec 10 2015, 3:03 PM · Differential, Restricted Project, Arcanist
epriestley moved T9859: `arc diff` allows addition of empty directories in SVN but `arc patch` creates files from Backlog to arc patch on the Arcanist board.
Dec 10 2015, 3:03 PM · FreeBSD, Arcanist, Subversion
epriestley moved T1022: arc patch fails to properly apply a patch which changes a symlink to a real file from Backlog to arc patch on the Arcanist board.
Dec 10 2015, 3:03 PM · Arcanist
epriestley closed T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same as Resolved.

The Git issues have been resolved (see T9657).

Dec 10 2015, 3:02 PM · Restricted Project, Arcanist
epriestley closed T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same, a subtask of T9082: `arc land` creates unnecessary local `master` branch in Git, as Resolved.
Dec 10 2015, 3:02 PM · Arcanist
epriestley closed T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same, a subtask of T9537: Support for landing without local tracking branch, as Resolved.
Dec 10 2015, 3:02 PM · Arcanist
epriestley closed T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same, a subtask of T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote, as Resolved.
Dec 10 2015, 3:02 PM · Arcanist
epriestley created T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.
Dec 10 2015, 3:00 PM · Mercurial, Arcanist
epriestley moved T9784: `arc patch`: Directory move in SVN patch workflow is implemented erroneously from Backlog to arc patch on the Arcanist board.
Dec 10 2015, 2:54 PM · Subversion, Arcanist
epriestley closed T9657: Upgrading: arc land flow has been rewritten in git as Resolved.

This has been live for about a month without any major issues cropping up.

Dec 10 2015, 2:46 PM · Installing & Upgrading, Arcanist
epriestley closed T9723: When landing a branch tracking upstream, try switching to local tracking branch of the same name as Resolved.

Resolved by D14420.

Dec 10 2015, 2:45 PM · Arcanist
epriestley closed Q244: help! click "edit task" or "create subtask",shows 404 as resolved.
Dec 10 2015, 2:40 PM
epriestley added Q244: help! click "edit task" or "create subtask",shows 404 (Answer 280).
Dec 10 2015, 2:40 PM
epriestley renamed T9947: "Expand File" keyboard shortcut in Differential should work on files which were not loaded by default from Add a keyboard shortcut for "Load File" in Differential to "Expand File" keyboard shortcut in Differential should work on files which were not loaded by default.
Dec 10 2015, 2:36 PM · Restricted Project, Differential, Feature Request
epriestley added a comment to T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.

Broad update here after T9132:

Dec 10 2015, 2:00 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley added a comment to T9946: Not adding archived owner packages as auditors on audits.

No problem -- it's easier for us to merge duplicates than split tasks apart, so it's not bad to err on the side of filing new tasks.

Dec 10 2015, 1:48 PM · Owners, Feature Request
epriestley closed T9132: Build an ApplicationEditor abstraction, a subtask of T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges, as Resolved.
Dec 10 2015, 1:43 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley closed T9132: Build an ApplicationEditor abstraction as Resolved.

I'm going to close this out since the infrastructure work it describes is now substantially complete, although a great deal of work remains to be done to bring this infrastructure to all applications and implement the full set of features it enables (mostly described in tasks blocked by this one).

Dec 10 2015, 1:43 PM · Restricted Project, ApplicationEditor, Transactions
epriestley closed T9132: Build an ApplicationEditor abstraction, a subtask of T4768: Phabricator silently overwrites concurrent changes (no conflict detection), as Resolved.
Dec 10 2015, 1:43 PM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
epriestley closed T9132: Build an ApplicationEditor abstraction, a subtask of T4316: Allow a comment to be added on the Maniphest edit interface, as Resolved.
Dec 10 2015, 1:43 PM · Maniphest
epriestley closed T9132: Build an ApplicationEditor abstraction, a subtask of T5031: Draft Comment Persists After Submission, as Resolved.
Dec 10 2015, 1:43 PM · Restricted Project, Support Impact, Mobile
epriestley closed T9132: Build an ApplicationEditor abstraction, a subtask of T5815: Make it easier to work through a queue of stuff, as Resolved.
Dec 10 2015, 1:43 PM · Restricted Project, Maniphest, Differential, Audit
epriestley closed T9132: Build an ApplicationEditor abstraction, a subtask of T8434: Accommodate the "Security" workflow, as Resolved.
Dec 10 2015, 1:43 PM · Wikimedia, Policy, Prioritized
epriestley closed T9132: Build an ApplicationEditor abstraction, a subtask of T7820: Add "Closed, Duplicate" option to Status Action in Maniphest, as Resolved.
Dec 10 2015, 1:43 PM · Restricted Project, User Delight, Maniphest
epriestley closed T9132: Build an ApplicationEditor abstraction, a subtask of T9238: Field-level policy controls are not made clear in the UI, as Resolved.
Dec 10 2015, 1:43 PM · Maniphest
epriestley closed T9132: Build an ApplicationEditor abstraction, a subtask of T9527: Confusing "... shifted this object from the S1 Public space to...", as Resolved.
Dec 10 2015, 1:43 PM · Transactions
epriestley merged task T9946: Not adding archived owner packages as auditors on audits into T9491: When packages are archived, packages shouldn't be listed as auditor.
Dec 10 2015, 1:30 PM · Owners, Feature Request
epriestley updated subscribers of T9491: When packages are archived, packages shouldn't be listed as auditor.
Dec 10 2015, 1:30 PM · Restricted Project, Owners
epriestley added a comment to T9946: Not adding archived owner packages as auditors on audits.

I'm going to merge this into T9491, since that's the existing task covering the primary issue here.

Dec 10 2015, 1:30 PM · Owners, Feature Request
epriestley added a comment to T9944: Figure out what happens when you archive a badge.

First approaches that come to mind, for whatever that's worth:

Dec 10 2015, 1:27 PM · Badges
epriestley added a revision to T9945: Unable to delete owner packages, it does not implement PhabricatorDestructibleInterface: Unknown Object (Differential Revision).
Dec 10 2015, 1:18 PM · Owners, Bug Report
epriestley claimed T9945: Unable to delete owner packages, it does not implement PhabricatorDestructibleInterface.
Dec 10 2015, 1:15 PM · Owners, Bug Report

Dec 9 2015

epriestley added a comment to T9943: why won't phabricator make me a sandwich?.

To clarify, you want Phabricator to turn you into a sandwich?

Dec 9 2015, 6:51 PM · Public & Media Relations, Feature Request
epriestley updated the task description for T9905: Upgrading: ApplicationEditor changes in Maniphest.
Dec 9 2015, 6:13 PM · Maniphest, Installing & Upgrading
epriestley added a comment to T8434: Accommodate the "Security" workflow.

I ultimately expanded the scope here into a lot of adjacent work in T9132, but a rough version of "better templating" is now available in HEAD and deployed and configured on this server. There's documentation here:

Dec 9 2015, 5:44 PM · Wikimedia, Policy, Prioritized
epriestley closed T9919: Display change between usernames for custom field of type "user" instead the PHID-USER-* in the Recent Activity feed as Resolved by committing Restricted Diffusion Commit.
Dec 9 2015, 5:04 PM · Custom Fields, Feed
epriestley added a revision to T9919: Display change between usernames for custom field of type "user" instead the PHID-USER-* in the Recent Activity feed: Unknown Object (Differential Revision).
Dec 9 2015, 5:01 PM · Custom Fields, Feed
epriestley closed T9941: Import a repository: Perforce: Link is dead as Resolved by committing Restricted Diffusion Commit.
Dec 9 2015, 4:51 PM · Bug Report
epriestley claimed T9941: Import a repository: Perforce: Link is dead.
Dec 9 2015, 4:51 PM · Bug Report
epriestley added a revision to T9941: Import a repository: Perforce: Link is dead: Unknown Object (Differential Revision).
Dec 9 2015, 4:50 PM · Bug Report
epriestley edited P1905 audit_project_mfa.sql.
Dec 9 2015, 4:25 PM
epriestley closed T9940: Revision Project Reviewers state not updated after reviewer added to project as Wontfix.

I think this is probably not something we're going to fix.

Dec 9 2015, 4:21 PM · Bug Report
epriestley added a comment to P1905 audit_project_mfa.sql.
mysql> SELECT u.username User, p.name Project, IF(f.id IS NULL, "NO", "YES") "Has MFA" FROM local_user.user u LEFT JOIN local_user.edge ue ON ue.src = u.phid AND ue.type = 14 LEFT JOIN local_project.project p ON ue.dst = p.phid LEFT JOIN local_auth.auth_factorconfig f ON f.userPHID = u.phid WHERE p.name = 'Dog Project';
+------+-------------+---------+
| User | Project     | Has MFA |
+------+-------------+---------+
| dog  | Dog Project | NO      |
+------+-------------+---------+
1 row in set (0.00 sec)
Dec 9 2015, 4:02 PM
epriestley updated the title for P1905 audit_project_mfa.sql from untitled to audit_project_mfa.sql.
Dec 9 2015, 4:02 PM
epriestley added a comment to T9938: Maniphest Actions are improperly disabled/can lead to 404.

Ah, okay. I'm not sure what's going on there. I can't immediately reproduce that.

Dec 9 2015, 3:14 PM · Bug Report
epriestley added a comment to T9938: Maniphest Actions are improperly disabled/can lead to 404.

Nothing happened (was added to the text area)

Dec 9 2015, 3:10 PM · Bug Report
epriestley updated the task description for T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.
Dec 9 2015, 3:05 PM · Maniphest, Installing & Upgrading
epriestley closed T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events as Resolved by committing Restricted Diffusion Commit.
Dec 9 2015, 3:03 PM · Modernization, Maniphest
epriestley closed T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events, a subtask of T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed, as Resolved.
Dec 9 2015, 3:03 PM · Maniphest, Installing & Upgrading
epriestley added a comment to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.

Tech changes out of T9132 (see also T9905) put this on a relatively short timetable and this stuff is no longer active on the major edit workflows so I'm going to land T9860. We probably won't cut a stable this week, and will continue issuing guidance on upgrading smoothly through these changes.

Dec 9 2015, 3:02 PM · Modernization, Maniphest
epriestley closed T9920: Be able to set the sort of the transaction log or set when older changes need to be hidden as Resolved by committing Restricted Diffusion Commit.
Dec 9 2015, 2:59 PM · Transactions
epriestley added a comment to T9920: Be able to set the sort of the transaction log or set when older changes need to be hidden.

Specifically, the rule is that the lesser of:

Dec 9 2015, 2:59 PM · Transactions
epriestley added a comment to T9938: Maniphest Actions are improperly disabled/can lead to 404.

I couldn't include F1018337 in the original post?

Dec 9 2015, 2:51 PM · Bug Report
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

Additional errata:

Dec 9 2015, 2:50 PM · ApplicationEditor
epriestley added a revision to T9920: Be able to set the sort of the transaction log or set when older changes need to be hidden: Unknown Object (Differential Revision).
Dec 9 2015, 2:45 PM · Transactions
epriestley added a comment to T6884: Logging when a task has been marked as a blocker.

"Create Subtask" is a shortcut for "Create Task, then add it as a blocker for this one".

Dec 9 2015, 2:33 PM · Transactions, Maniphest
epriestley updated subscribers of T6884: Logging when a task has been marked as a blocker.
Dec 9 2015, 2:32 PM · Transactions, Maniphest
epriestley merged task T6672: Add transaction to the parent task when a subtask gets added via "Create Subtask" into T6884: Logging when a task has been marked as a blocker.
Dec 9 2015, 2:32 PM · Transactions, Maniphest
epriestley removed a project from T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog: Transactions.
Dec 9 2015, 2:31 PM · Maniphest
epriestley moved T9132: Build an ApplicationEditor abstraction from Backlog to vNext on the Transactions board.
Dec 9 2015, 2:30 PM · Restricted Project, ApplicationEditor, Transactions
epriestley moved T9527: Confusing "... shifted this object from the S1 Public space to..." from Backlog to vNext on the Transactions board.
Dec 9 2015, 2:30 PM · Transactions
epriestley moved T7661: Object creation is often accompanied by transaction records which aren't of much use from Backlog to vNext on the Transactions board.
Dec 9 2015, 2:29 PM · Transactions, Maniphest
epriestley moved T9077: Some applications don't support the "Quote" action on comments properly from Backlog to vNext on the Transactions board.
Dec 9 2015, 2:29 PM · Restricted Project, Transactions
epriestley moved T9920: Be able to set the sort of the transaction log or set when older changes need to be hidden from Backlog to vNext on the Transactions board.
Dec 9 2015, 2:29 PM · Transactions
epriestley added a comment to T9527: Confusing "... shifted this object from the S1 Public space to...".

T7661 is also similar.

Dec 9 2015, 2:29 PM · Transactions
epriestley removed a project from T5529: Clear Flags on Accept: Herald.
Dec 9 2015, 1:38 PM · Flags
epriestley moved T6207: Add a "Can Use Herald Rules" application permission from Backlog to Next on the Herald board.
Dec 9 2015, 1:37 PM · Restricted Project, Policy, Herald
epriestley moved T7804: Implement an "Acting User" Herald condition from Backlog to Next on the Herald board.
Dec 9 2015, 1:37 PM · Restricted Project, Herald, Mail
epriestley added a comment to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

Actually, that report is already fixed.

Dec 9 2015, 1:35 PM · Documentation, Herald
epriestley added a comment to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

Actually, that report is already fixed. For completeness, the behavior adapters should have is:

Dec 9 2015, 1:34 PM · Documentation, Herald
epriestley added a comment to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

See also T7961, which is another modular behavior adapters should have.

Dec 9 2015, 1:33 PM · Documentation, Herald
epriestley moved T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules from Backlog to Next on the Herald board.
Dec 9 2015, 1:33 PM · Applications, Herald
epriestley closed T8682: Commit hooks should have better notification options for committers as Wontfix.
  • You can now technically write this as an extension by extending HeraldAction, although mail is quite complicated and this extension may be challenging to write.
  • You could use an extension like the one in P1895 to add a comment instead, although I think this will be caught by notification preferences.
  • You can use the action above (reject commit unless they bypass).
  • You could use "Add Projects" and then just manually email the offenders who got hit at the end of the week to warn them.
Dec 9 2015, 1:32 PM · Notifications, Herald
epriestley added a comment to T8952: Hide "Herald added subscribers..." stories from feed completely.

Offhand, I'm inclined to still publish "Herald closed the task." in the "subscribe + close" hypothetical, which I think is the current behavior.

Dec 9 2015, 1:26 PM · Feed, Herald
epriestley added a comment to T8952: Hide "Herald added subscribers..." stories from feed completely.

This behavior is "correct" in some sense (Herald really did perform the "strongest" action in the transaction group) but the sorting on tiebreakers is likely wrong (see D14680 for a similar case) and we should sort actions by real users over actions by Herald at the same strength.

Dec 9 2015, 1:24 PM · Feed, Herald
epriestley moved T8952: Hide "Herald added subscribers..." stories from feed completely from Backlog to Next on the Herald board.
Dec 9 2015, 1:16 PM · Feed, Herald
epriestley closed T9071: Herald rule supports Differential Revision dependent processing as Wontfix.

The build for Dyyyy should not fail. They do not fail in the upstream.

Dec 9 2015, 1:16 PM · Differential, Herald
epriestley added a comment to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

Related, the test console has a big if ($x instanceof ...) mess that should be pushed down into Adapters. A reasonable flow might be:

Dec 9 2015, 1:14 PM · Documentation, Herald
epriestley renamed T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess from Herald test console doesn't appear to work for commit hooks (pre-receive) to Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.
Dec 9 2015, 1:12 PM · Documentation, Herald
epriestley moved T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess from Backlog to Next on the Herald board.
Dec 9 2015, 1:12 PM · Documentation, Herald
epriestley closed T9700: Change maniphest tasks depending on project memberships. as Wontfix.

The new tools from T9132 are now in HEAD (see D14718 for documentation, which will land shortly).

Dec 9 2015, 1:11 PM · Herald