Page MenuHomePhabricator

Herald rule supports Differential Revision dependent processing
Closed, WontfixPublic


dependent.png (726×1 px, 35 KB)

Currently, dependent is not handled when adding a Herald rule to trigger build plan on Differential Revisions.

Suppose Dyyyy depends on Dxxxx which is not closed yet.

A build plan triggered by Dyyyy will likely to fail. The solution here could be like below

1, only trigger the build plan for Differential update without any denepedent (Thus Dyyyy will not trigger the build plan)
Here, arcanist need to be able to set the dependent status (NO, YES/Dxxxx) when generating Dyyyy via "arc diff"

2, trigger the build plan for Dyyyy when Dxxxx is closed

Event Timeline

lianghu assigned this task to epriestley.
lianghu raised the priority of this task from to Needs Triage.
lianghu updated the task description. (Show Details)
lianghu added a project: Herald.
lianghu added a subscriber: lianghu.
lianghu renamed this task from Herald rule support deal with Differential dependent case to Herald rule supports Differential Revision dependent processing.Aug 5 2015, 7:32 AM

The build for Dyyyy should not fail. They do not fail in the upstream.

One way to make sure they don't fail is to use "Staging Areas". See: