Page MenuHomePhabricator
Create Task
Maniphest T9936

During arc land harbormaster failure, cannot tell if "arc lint" or "arc unit" failed
Closed, DuplicatePublic
Actions

Description

I see a message somewhat like this.

Harbormaster failed to build the active diff for this revision. Build failures:

     FAILED  Build 52326: arc lint + arc unit

You can review build details here:

    Harbormaster URI: https://tails.corp.dropbox.com/B52279

    Land revision anyway, despite build failures? [y/N] y

From this message, I can't tell if it's a lint failure or unit failure without clicking through. This becomes a hinderance when the internal policy for lint and unit differ.

T8856 appears to help with the issue if it were expanded to show both lint and unit errors, but I would prefer not to combine lint/unit into one monolith in the results since they do fundamentally different operations.

Related Objects

Event Timeline

nipunn created this task.Dec 9 2015, 12:19 AM
nipunn raised the priority of this task from to Needs Triage.
nipunn updated the task description. (Show Details)
nipunn changed the edit policy from "All Users" to "Custom Policy".
nipunn added a project: Bug Report.
nipunn added a project: Restricted Project.
nipunn added a subscriber: nipunn.
Herald added a subscriber: jhurwitz. · View Herald TranscriptDec 9 2015, 12:19 AM
nipunn added a subscriber: angie.Dec 9 2015, 12:20 AM
epriestley added a subscriber: epriestley.Dec 9 2015, 12:27 AM

The expectation is that you'll remember what the issue was, since arc diff printed the specific problems earlier and you already explicitly confirmed that you wanted to continue despite the issues.

My personal experience is that I'm nearly always able to remember, and in the rare cases when I don't it isn't a big deal to remind myself via the web UI. Does your experience differ? Is there any particular reason that you can't remember? (Maybe you submit a lot more diffs than I do.)

epriestley mentioned this in T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff.Dec 9 2015, 12:33 AM
nipunn closed this task as a duplicate of T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff.Dec 9 2015, 12:53 AM
joshuaspence added projects: Arcanist, Harbormaster.Dec 9 2015, 10:02 AM
joshuaspence added a subscriber: joshuaspence.
angie added a comment.Dec 10 2015, 6:53 PM

@nipunn, can you please reset the object policy on this task so that we can move it to the correct column on the workboard?

epriestley added a comment.Dec 10 2015, 6:54 PM

@angie, I added you to Community so you should have sweeping powers on this install now.

angie moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Dec 10 2015, 6:55 PM
Phabricator · Built by Phacility