Page MenuHomePhabricator
Create Task
Maniphest T7961

In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules
Closed, ResolvedPublic
Actions

Description

Hi all,

On our installation of phabricator which has neither legalpad nor harbormaster installed, when creating a herald rule both of these options show up: https://www.dropbox.com/s/p0z6r5eqj0awgwq/Screenshot%202015-04-27%2011.41.59.png?dl=0

Herald should not offer the option to require features from applications which are non-functional.

(I'm uncertain about what to do with rules set up prior to them being uninstalled)

Revisions and Commits

rP Phabricator
D20808rPd60d4e6a0521 Don't present users with Herald fields/actions for uninstalled applications…

Related Objects

Event Timeline

eadler created this task.Apr 27 2015, 6:43 PM
eadler raised the priority of this task from to Needs Triage.
eadler updated the task description. (Show Details)
eadler added projects: Herald, Applications.
eadler added a project: User Delight.
eadler added a subscriber: eadler.
joshuaspence added a subscriber: joshuaspence.Apr 27 2015, 8:46 PM
epriestley triaged this task as Wishlist priority.Apr 27 2015, 8:49 PM
epriestley removed a project: User Delight.
epriestley moved this task from Backlog to Next on the Herald board.Dec 9 2015, 1:33 PM
epriestley mentioned this in T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.
• yurotet renamed this task from Herald should not show actions for uninstalled applications to daglkasdjl fkefdsfe .Dec 10 2015, 10:50 AM
• yurotet added a subscriber: • yurotet.
johnny-bit renamed this task from daglkasdjl fkefdsfe to Herald should not show actions for uninstalled applications.Dec 10 2015, 11:04 AM
johnny-bit edited subscribers, added: johnny-bit; removed: • yurotet.
epriestley added subscribers: lpriestley, epriestley.Dec 14 2015, 5:31 PM

Two aspects here, one or both of which may already be partially or fully implemented:

  • Herald → Create Herald Rule should not show any options for applications which aren't installed for the viewer.
  • Application-specific conditions (like "User's projects include") and actions (like "Require Legalpad Signature") should not be available if the corresponding applications are not installed (do a global test here, not a viewer test, because the viewer may be examining or editing another user's rule, and that other user may have access).
epriestley added a parent task: T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.Jul 30 2016, 11:50 AM
epriestley claimed this task.Aug 1 2016, 6:26 PM
epriestley added a comment.Aug 1 2016, 6:30 PM

Oh, I think I made up point (1) above -- that's already the behavior.

Point (2) is worth fixing at some point, but not relevant to T7939.

epriestley removed epriestley as the assignee of this task.Aug 1 2016, 6:30 PM
epriestley removed a parent task: T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.
epriestley renamed this task from Herald should not show actions for uninstalled applications to In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules.Jan 26 2018, 5:33 PM
Herald added a subscriber: amckinley. · View Herald TranscriptMay 27 2019, 2:15 PM
epriestley added a revision: D20808: Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them.Sep 12 2019, 7:57 PM
epriestley closed this task as Resolved.Sep 12 2019, 7:58 PM
epriestley claimed this task.

D20808 fixes the two original cases (Harbormaster and Legalpad). There are probably more fields or actions which could be configured to be sometimes-unavailable, but these are probably the major ones.

epriestley added a commit: rPd60d4e6a0521: Don't present users with Herald fields/actions for uninstalled applications….Sep 12 2019, 9:33 PM
Phabricator · Built by Phacility