Page MenuHomePhabricator
Create Task
Maniphest T9077

Some applications don't support the "Quote" action on comments properly
Open, NormalPublic
Actions

Description

I've noticed that quotes don't work in Paste and Audit (and maybe a few other places). That is, I can't click onto a comment in the timeline and quote it.

Revisions and Commits

rP Phabricator
AbandonedD14416 Make all comments quotable

Related Objects

Event Timeline

joshuaspence created this task.Aug 5 2015, 12:46 PM
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added projects: Audit, Paste.
joshuaspence added a subscriber: joshuaspence.
• dralin closed this task as Resolved.Aug 5 2015, 7:39 PM
• dralin claimed this task.
• dralin added a subscriber: • dralin.
• dralin removed a subscriber: • dralin.
• dralin reopened this task as Open.Aug 5 2015, 7:41 PM
• dralin removed • dralin as the assignee of this task.
• dralin added a subscriber: • dralin.

sdad tresdtt

testtest//test[[

  • URL

    | name ]]//****
• dralin closed this task as Resolved.Aug 5 2015, 7:44 PM
• dralin claimed this task.
• dralin removed a subscriber: • dralin.
epriestley reopened this task as Open.Aug 5 2015, 7:50 PM
epriestley removed • dralin as the assignee of this task.
chad added subscribers: epriestley, chad.Aug 6 2015, 4:34 AM

@epriestley is this a migration thing or just modernizing?

epriestley added a comment.Aug 6 2015, 4:36 AM

Modernizing -- the timeline needs setQuoteTargetID() and setQuoteRef() to activate "Quote". This should be more automatic than it is, but the comment boxes are custom per app right now. If you want to go manually add the calls now that'll work, or we can wait until this gets a general modernization pass and should pick it up for free.

joshuaspence claimed this task.Sep 6 2015, 7:57 AM
joshuaspence triaged this task as Normal priority.
joshuaspence added a comment.Oct 15 2015, 2:45 AM

Quotes also don't work in Ponder.

joshuaspence added a revision: D14416: Make all comments quotable.Nov 5 2015, 8:09 PM
epriestley added a comment.Dec 5 2015, 9:21 PM

See also D14665 for EditEngine integration, which slightly changes one call.

epriestley added a comment.Dec 5 2015, 9:26 PM

I also made them work in Paste, so generalizing this task per D14416.

epriestley renamed this task from Quotes don't work in paste and audit to Some applications don't support the "Quote" action on comments properly.Dec 5 2015, 9:26 PM
epriestley edited projects, added Transactions; removed Paste, Audit.
epriestley moved this task from Backlog to vNext on the Transactions board.Dec 9 2015, 2:29 PM
eadler added a project: Restricted Project.Aug 5 2016, 5:23 PM
Herald added a subscriber: eadler. · View Herald TranscriptAug 5 2016, 5:23 PM
Phabricator · Built by Phacility