Page MenuHomePhabricator

Not adding archived owner packages as auditors on audits
Closed, DuplicatePublic

Description

This feature has to do with one person owner packages. For example, if 2 developers are in an owner package and 1 developers leaves the project, there is only one developer left in the owner package. This one developer should not be reviewing is own commit.

Owner packages can be archived however, so it would make sense if archived owner packages would not be added as auditors.
This, at this moment, is not the case however. If I archive the owner package, this package is still being added as an auditor for codereviews.

This is a problem. Because this auditor will never be able to accept the commit. Because the only "real person" left in this package is the author of the commit. And an author should never be able to accept his own commits.

For us this is a bit of a problem, because we have quite a few audits that we are unable to properly close.

I am not sure if this is intentional or a bug. If it is a bug, feel free to let me know and I will make this a bug report.

Event Timeline

JohnHeroHD raised the priority of this task from to Needs Triage.
JohnHeroHD updated the task description. (Show Details)
JohnHeroHD changed the edit policy from "All Users" to "Custom Policy".
JohnHeroHD added a project: Feature Request.
JohnHeroHD updated the task description. (Show Details)
JohnHeroHD added a subscriber: JohnHeroHD.

I'm going to merge this into T9491, since that's the existing task covering the primary issue here.

T7676 is also somewhat related.

I'm going to merge this into T9491, since that's the existing task covering the primary issue here.

T7676 is also somewhat related.

Fine by me, thanks, and sorry for the duplicate!

No problem -- it's easier for us to merge duplicates than split tasks apart, so it's not bad to err on the side of filing new tasks.