Page MenuHomePhabricator

OwnersProject
ActivePublic

Members (2)

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

Who owns the owners tool?

Recent Activity

Mon, Feb 3

epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20962: Fix an issue where Herald rules could fail to evaluate at post-commit time.
Mon, Feb 3, 1:05 PM · Projects, Owners, Herald
epriestley added a comment to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields.

See https://discourse.phabricator-community.org/t/herald-rule-not-adding-auditors-to-commits-following-upgrade/3505 for one bug with this.

Mon, Feb 3, 1:04 PM · Projects, Owners, Herald

Wed, Jan 29

epriestley closed T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields as Resolved by committing rPc99485e8a00d: Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and….
Wed, Jan 29, 11:52 PM · Projects, Owners, Herald
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20957: Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and Hooks.
Wed, Jan 29, 10:56 PM · Projects, Owners, Herald
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20956: Update Herald rule creation workflow to use more modern UI elements.
Wed, Jan 29, 8:40 PM · Projects, Owners, Herald
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20955: In Herald "Commit" rules, use repository identities to identify authors and committers.
Wed, Jan 29, 6:40 PM · Projects, Owners, Herald

Jan 24 2020

epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20953: Respect repository identities when figuring out authors/committers in Herald pre-commit hook rules.
Jan 24 2020, 1:16 AM · Projects, Owners, Herald

Jan 23 2020

epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20951: In Herald transcripts, render some field values in a more readable way.
Jan 23 2020, 11:38 PM · Projects, Owners, Herald
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20949: In Herald transcript rendering, don't store display labels in keys.
Jan 23 2020, 7:51 PM · Projects, Owners, Herald
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20948: Remove legacy pre-loading of handles from Herald rendering.
Jan 23 2020, 7:42 PM · Projects, Owners, Herald
epriestley added a comment to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields.

Remaining work:

Jan 23 2020, 2:43 AM · Projects, Owners, Herald
epriestley added a comment to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields.

D20947 does not implement "Author's packages" as a "Commit Content" field, nor as a "Commit Content (Hook)" field. The reason for this is that getting the modern authorPHID in both cases is somewhat complicated.

Jan 23 2020, 2:20 AM · Projects, Owners, Herald
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20947: Implement an "Author's packages" Herald field for Differential.
Jan 23 2020, 2:17 AM · Projects, Owners, Herald

Jan 21 2020

epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: D20946: Add "Project tags added" and "Project tags removed" fields in Herald.
Jan 21 2020, 7:31 PM · Projects, Owners, Herald

Jan 17 2020

epriestley triaged T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields as Wishlist priority.
Jan 17 2020, 5:05 PM · Projects, Owners, Herald

Nov 21 2019

epriestley closed T13464: Fix "display" index issue when editing Paths in Owners as Resolved by committing rP2abf292821a2: Fix an issue where editing paths in Owners packages could raise an error….
Nov 21 2019, 7:29 PM · Owners
epriestley added a revision to T13464: Fix "display" index issue when editing Paths in Owners: D20923: Fix an issue where editing paths in Owners packages could raise an error: undefined index "display".
Nov 21 2019, 7:27 PM · Owners
epriestley triaged T13464: Fix "display" index issue when editing Paths in Owners as Low priority.
Nov 21 2019, 7:18 PM · Owners

Jun 20 2019

epriestley closed T13324: Owners transactions which edit paths for packages with one or more paths with no trailing slash render incorrectly as Resolved by committing rP53f8ad14fa92: Fix an issue in Owners where a transaction change could show too many effects.
Jun 20 2019, 11:08 PM · Owners
epriestley added a revision to T13324: Owners transactions which edit paths for packages with one or more paths with no trailing slash render incorrectly: D20596: Fix an issue in Owners where a transaction change could show too many effects.
Jun 20 2019, 6:16 PM · Owners
epriestley claimed T13324: Owners transactions which edit paths for packages with one or more paths with no trailing slash render incorrectly.
Jun 20 2019, 6:11 PM · Owners
epriestley added a comment to T5758: Package auditing should only require auditing on closing branches.

This was effectively resolved in 2019 Week 17 (Very Late April). Now, only ancestors of "Permanent Refs" trigger any publishing behavior (audits, notifications, feed, etc).

Jun 20 2019, 5:45 PM · Restricted Project, Owners
epriestley added a comment to T11012: Audit not Triggered Sometimes in Owners/Packages Application.

This is very old and it doesn't look like we ever found a working set of reproduction steps.

Jun 20 2019, 5:43 PM · Restricted Project, Owners, Bug Report
epriestley created T13324: Owners transactions which edit paths for packages with one or more paths with no trailing slash render incorrectly.
Jun 20 2019, 5:27 PM · Owners

May 3 2019

epriestley closed T11118: Herald Rule to assign Owners to an Audit as Wontfix.

Owners review and auditing now have 6 and 4 options respectively, which I think cover most of the needs here. They don't handle everything (e.g. excluding merge commits) but think we're mostly in a reasonable place now and don't have any current plans to add additional shorthands.

May 3 2019, 4:39 AM · Restricted Project, Audit, Herald, Owners, Feature Request

Mar 13 2018

jbrownEP added a comment to T11002: permit wildcards in OWNERs paths.

Yeah, that was the commit that reminded me how I wanted this. Unfortunately, it looks like the database still stores literal repositoryPHIDs, so the schema would need to change if it were to handle functions (which is why I bumped the ticket instead of taking a stab at implementing it myself first). I figured I'd add my voice to the ticket for now and continue toiling along with complex Herald rules for now.

Mar 13 2018, 7:05 PM · FreeBSD, Owners, Feature Request
epriestley added a comment to T11002: permit wildcards in OWNERs paths.

After D19191 it would be relatively easy to support projects and wildcard functions (like "Any Repository") but there's currently no interest in this from customers.

Mar 13 2018, 6:59 PM · FreeBSD, Owners, Feature Request
jbrownEP added a comment to T11002: permit wildcards in OWNERs paths.

I don't suppose there's been any interest in adding wildcards/function matchers to Owners in the last couple of years?

Mar 13 2018, 6:56 PM · FreeBSD, Owners, Feature Request

Mar 8 2018

epriestley closed T12590: Owners expects users to choose a repository with a <select /> that lists every repository in ID order as Resolved by committing rPa4cc1373d3a2: Use a tokenizer, not a gigantic poorly-ordered "<select />", to choose….
Mar 8 2018, 4:57 AM · Owners
epriestley added a revision to T12590: Owners expects users to choose a repository with a <select /> that lists every repository in ID order: D19191: Use a tokenizer, not a gigantic poorly-ordered "<select />", to choose repositories in Owners.
Mar 8 2018, 2:22 AM · Owners
epriestley added a revision to T12590: Owners expects users to choose a repository with a <select /> that lists every repository in ID order: D19190: Fix broken suggestion/validation for Owners paths in repositories with short names.
Mar 8 2018, 1:33 AM · Owners
epriestley added a revision to T12590: Owners expects users to choose a repository with a <select /> that lists every repository in ID order: D19189: Remove very old "owners-default-path" code from Owners.
Mar 8 2018, 12:44 AM · Owners

Mar 7 2018

epriestley closed T11015: Owners has perplexing behavior when directory paths are not terminated with a slash as Resolved.

I believe the behavior of this UI should generally align well with what reasonable users might expect, now. In particular, /src/backend and /src/backend/ are now exactly the same in terms of actually resolving ownership, although the UI will continue to show you the value you entered (to avoid confusion where someone types /docs/README.md and the UI echoes back /docs/README.md/ and they have a reasonable concern that the path wasn't understood).

Mar 7 2018, 4:54 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19185: Use "pathIndex" in some owners package queries to improve query plans.
Mar 7 2018, 4:28 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19184: Treat Owners paths like "/src/backend" and "/src/backend/" identically.
Mar 7 2018, 4:14 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19183: Allow owners paths to be arbitrarily long and add storage for display paths.
Mar 7 2018, 3:54 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19182: Add a unique key to OwnersPath on "<packageID, repositoryPHID, pathIndex>".
Mar 7 2018, 3:47 AM · Owners, Bug Report
epriestley added a revision to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash: D19181: Add and populate a `pathIndex` column for OwnersPath.
Mar 7 2018, 3:37 AM · Owners, Bug Report
epriestley added a comment to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash.

Probably better is to add pathIndex

Mar 7 2018, 3:25 AM · Owners, Bug Report

Feb 8 2018

epriestley closed T11363: Differential "revision updated" mail preference is pretty useless, a subtask of T10448: Modularize mail tags, as Resolved.
Feb 8 2018, 7:29 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley closed T10448: Modularize mail tags as Resolved.

I'm going to roll this forward into T13069, which discusses remaining work for "mail stamps".

Feb 8 2018, 7:29 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley closed T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc, a subtask of T10448: Modularize mail tags, as Resolved.
Feb 8 2018, 7:28 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley merged T10874: Add repository or project to email subject into T10448: Modularize mail tags.
Feb 8 2018, 5:13 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request

Feb 4 2018

epriestley added a revision to T10448: Modularize mail tags: D18991: Add basic support for mail "stamps" to improve client mail routing.
Feb 4 2018, 5:40 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request

Jan 27 2018

epriestley moved T10448: Modularize mail tags from v3 to Stamps/Failover on the Mail board.
Jan 27 2018, 9:57 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request

Aug 6 2017

chad closed T11651: Owners empty states are lookin' weird as Resolved.

seems ok now.

Aug 6 2017, 2:50 AM · Owners, Design

Jul 27 2017

epriestley merged T12939: Ponder seems to ignore all email settings into T10448: Modularize mail tags.
Jul 27 2017, 1:33 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley merged T12909: Calendar ignores email preferences if a user is invited via a project into T10448: Modularize mail tags.
Jul 27 2017, 1:31 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request

Jul 26 2017

jenn added a comment to T7547: Is there a way to specify a wildcard path in Owners?.

This would be great. For example, in a Xcode project I could create packages for translators/localizers for any path containing *.lproj/

Jul 26 2017, 10:36 PM · Owners

Jun 1 2017

epriestley added a comment to T12789: Confirm/remedy issues with duplicate Owners paths.

It's possible that didn't get everything, but yell if you hit anything else and we can shovel on some more test cases. Thanks for the report!

Jun 1 2017, 11:42 PM · Owners, Restricted Project, Bug Report, Customer Impact