Page MenuHomePhabricator

Add a unique key to OwnersPath on "<packageID, repositoryPHID, pathIndex>"
ClosedPublic

Authored by epriestley on Mar 7 2018, 3:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 12:58 AM
Unknown Object (File)
Feb 3 2024, 6:21 PM
Unknown Object (File)
Jan 2 2024, 1:41 AM
Unknown Object (File)
Dec 23 2023, 7:31 PM
Unknown Object (File)
Dec 22 2023, 12:11 AM
Unknown Object (File)
Dec 21 2023, 11:37 PM
Unknown Object (File)
Nov 30 2023, 4:32 AM
Unknown Object (File)
Nov 25 2023, 6:48 PM
Subscribers
None

Details

Summary

Depends on D19181. Ref T11015. This nukes duplicates from the table if they exist, then adds a unique key.

(Duplicates should not exist and can not be added with any recent version of the web UI.)

Test Plan
  • Tried to add duplicates with web UI, didn't have any luck.
  • Explicitly added duplicates with manual INSERTs.
  • Viewed packages in web UI and saw duplicates.
  • Ran migrations, got a clean purge and a nice unique key.
  • There's still no way to actually hit a duplicate key error in the UI (unless you can collide hashes, I suppose), this is purely a correctness/robustness change.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable