Page MenuHomePhabricator

In Herald transcript rendering, don't store display labels in keys
ClosedPublic

Authored by epriestley on Jan 23 2020, 7:51 PM.
Tags
None
Referenced Files
F13062501: D20949.diff
Sat, Apr 20, 12:23 AM
Unknown Object (File)
Thu, Apr 11, 8:59 AM
Unknown Object (File)
Thu, Apr 4, 1:38 AM
Unknown Object (File)
Sun, Mar 31, 10:09 PM
Unknown Object (File)
Feb 23 2024, 6:22 PM
Unknown Object (File)
Feb 20 2024, 8:17 PM
Unknown Object (File)
Feb 13 2024, 10:25 AM
Unknown Object (File)
Feb 3 2024, 11:32 PM
Subscribers
None

Details

Summary

Ref T13480. Currently, when Herald renders a transcript, it puts display labels into array keys. This is a bad pattern for several reasons, notably that the values must be scalar (so you can't add icons or other markup later) and the values must be unique (which is easily violated because many values are translated).

Instead, keep values as list items.

Test Plan

Viewed Herald transcripts, saw no (meaningful) change in rendering output.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jan 29 2020, 11:11 PM
This revision was automatically updated to reflect the committed changes.