Page MenuHomePhabricator

In Herald transcript rendering, don't store display labels in keys
ClosedPublic

Authored by epriestley on Jan 23 2020, 7:51 PM.

Details

Summary

Ref T13480. Currently, when Herald renders a transcript, it puts display labels into array keys. This is a bad pattern for several reasons, notably that the values must be scalar (so you can't add icons or other markup later) and the values must be unique (which is easily violated because many values are translated).

Instead, keep values as list items.

Test Plan

Viewed Herald transcripts, saw no (meaningful) change in rendering output.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 23 2020, 7:51 PM
epriestley requested review of this revision.Jan 23 2020, 7:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 29 2020, 11:11 PM
This revision was automatically updated to reflect the committed changes.