Page MenuHomePhabricator

Add "Project tags added" and "Project tags removed" fields in Herald
ClosedPublic

Authored by epriestley on Jan 21 2020, 7:31 PM.

Details

Summary

Ref T13480. These fields don't serve a specific strong use case, but are broadly reasonable capabilities after "state" vs "change" actions were relaxed by T13283.

Test Plan

Wrote rules using the new fields, added and removed projects (and did neither) to fire them / not fire them. Inspected the transcripts to see the project PHIDs making it to the field values.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 21 2020, 7:31 PM
epriestley requested review of this revision.Jan 21 2020, 7:33 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 23 2020, 2:21 AM
This revision was automatically updated to reflect the committed changes.