Page MenuHomePhabricator

In Herald transcripts, render some field values in a more readable way
ClosedPublic

Authored by epriestley on Jan 23 2020, 11:38 PM.

Details

Summary

Ref T13480. Currently, some Herald field types are rendered in an unfriendly way on transcripts. Particularly, PHID lists are rendered as raw PHIDs.

Improve this by delegating rendering to Value objects and letting "PHID List" value objects render more sensible handle lists. Also improve "bool" fields a bit and make more fields render an explicit "None" / empty value rather than just rendering nothing.

Test Plan

Viewed various transcripts, including transcripts covering boolean values, the "Always" condition, large blocks of text, and PHID lists.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 23 2020, 11:38 PM
epriestley requested review of this revision.Jan 23 2020, 11:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jan 29, 11:14 PM
This revision was automatically updated to reflect the committed changes.