Page MenuHomePhabricator

Owners transactions which edit paths for packages with one or more paths with no trailing slash render incorrectly
Closed, ResolvedPublic

Description

See PHI1288. When:

  • an Owners package has one or more paths with no trailing slash (/README.md); and
  • you edit the paths and make some unrelated change (e.g., add a totally new path); and
  • you click "Show Details" on the resulting transaction; then
  • we expect the details to show only the paths you actually changed.

Actual behavior is that the path with no / shows up in the edit because of what looks like a normalization issue:

Screen Shot 2019-05-30 at 7.30.05 AM.png (289×834 px, 33 KB)

Instead, the transaction should likely record display paths, and normalization should occur later than it currently does.

Revisions and Commits

Restricted Differential Revision

Event Timeline

epriestley created this task.
epriestley added a revision: Restricted Differential Revision.Jun 20 2019, 6:16 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jun 20 2019, 11:08 PM
epriestley added a commit: Restricted Diffusion Commit.