Page MenuHomePhabricator

Fix an issue where editing paths in Owners packages could raise an error: undefined index "display"
ClosedPublic

Authored by epriestley on Thu, Nov 21, 7:27 PM.

Details

Summary

Fixes T13464. Fully-realized paths have a "path" (normalized, effective path) and a "display" path (user-facing, un-normalized path).

During transaction validation we build ref keys for paths before we normalize the "display" values. A few different approaches could be taken to resolve this, but just default the "display" path to the raw "path" if it isn't present since that seems simplest.

Test Plan

Edited paths in an Owners package, no longer saw a warning in the logs.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Nov 21, 7:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Nov 21, 7:28 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.