Page MenuHomePhabricator

Update Herald rule creation workflow to use more modern UI elements
ClosedPublic

Authored by epriestley on Jan 29 2020, 8:40 PM.

Details

Summary

Ref T13480. Creating a rule in Herald currently uses the older radio-button flow. Update it to the "clickable menu" flow to simplify it a little bit.

Test Plan

Created new personal, object, and global rules. Hit the object rule error conditions.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 29 2020, 8:40 PM
epriestley requested review of this revision.Jan 29 2020, 8:41 PM
epriestley updated this revision to Diff 49952.Feb 4 2020, 3:35 PM
  • Rebase and use "PHUILauncherView" in the new UIs.
This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 3:37 PM
This revision was automatically updated to reflect the committed changes.