Page MenuHomePhabricator

Use a tokenizer, not a gigantic poorly-ordered "<select />", to choose repositories in Owners
ClosedPublic

Authored by epriestley on Mar 8 2018, 2:22 AM.

Details

Summary

Depends on D19190. Fixes T12590. Ref T13099. Replaces the barely-usable, gigantic, poorly ordered "<select />" control with a tokenizer. Attempts to fix various minor issues.

Test Plan
  • Edited paths: include/exclude paths, from different repositories, different actual paths.
  • Used "Add New Path" to add rows, got repository selector prepopulated with last value.
  • Used "remove".
  • Used validation typeahead, got reasonable behaviors?

The error behavior if you delete the repository for a path is a little sketchy still, but roughly okay.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 4:57 AM
This revision was automatically updated to reflect the committed changes.