Page MenuHomePhabricator

Use a tokenizer, not a gigantic poorly-ordered "<select />", to choose repositories in Owners
ClosedPublic

Authored by epriestley on Mar 8 2018, 2:22 AM.
Tags
None
Referenced Files
F18387322: D19191.id45962.diff
Fri, Aug 29, 3:10 AM
F18387296: D19191.id.diff
Fri, Aug 29, 3:09 AM
F18105891: D19191.id45962.diff
Sun, Aug 10, 8:22 PM
F18094961: D19191.diff
Thu, Aug 7, 10:27 PM
F18093191: D19191.id.diff
Thu, Aug 7, 4:13 PM
F18091211: D19191.diff
Wed, Aug 6, 8:15 PM
Unknown Object (File)
Jul 1 2025, 4:28 AM
Unknown Object (File)
Jun 2 2025, 3:19 PM
Subscribers
None

Details

Summary

Depends on D19190. Fixes T12590. Ref T13099. Replaces the barely-usable, gigantic, poorly ordered "<select />" control with a tokenizer. Attempts to fix various minor issues.

Test Plan
  • Edited paths: include/exclude paths, from different repositories, different actual paths.
  • Used "Add New Path" to add rows, got repository selector prepopulated with last value.
  • Used "remove".
  • Used validation typeahead, got reasonable behaviors?

The error behavior if you delete the repository for a path is a little sketchy still, but roughly okay.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 4:57 AM
This revision was automatically updated to reflect the committed changes.