Page MenuHomePhabricator
Differential D20957

Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and Hooks
ClosedPublic
Actions

Authored by epriestley on Jan 29 2020, 10:56 PM.

Details

Reviewers
None
Maniphest Tasks
T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields
Commits
rPc99485e8a00d: Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and…
Summary

Fixes T13480. Adds the remaining missing Owners package rules for Herald commit adapters.

Test Plan

Created hooks which care about these fields, pushed commits, saw sensible transcript values.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 29 2020, 10:56 PM
epriestley requested review of this revision.Jan 29 2020, 10:58 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 29 2020, 11:52 PM
Closed by commit rPc99485e8a00d: Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPc99485e8a00d: Add "Author's Packages" and "Committer's Packages" Herald rules for Commits and….

Revision Contents
Changeset List

PathPackages
Msrc/__phutil_library_map__.php (8 lines)
Psrc/applications/diffusion/herald/DiffusionCommitAuthorPackagesHeraldField.php (18 lines)
Copied from src/applications/diffusion/herald/DiffusionCommitAuthorProjectsHeraldField.php
Psrc/applications/diffusion/herald/DiffusionCommitAuthorProjectsHeraldField.php (6 lines)
Copied to multiple locations:
src/applications/diffusion/herald/DiffusionCommitAuthorPackagesHeraldField.php
src/applications/diffusion/herald/DiffusionCommitCommitterPackagesHeraldField.php
Psrc/applications/diffusion/herald/DiffusionCommitCommitterPackagesHeraldField.php (18 lines)
Copied from src/applications/diffusion/herald/DiffusionCommitAuthorProjectsHeraldField.php
Msrc/applications/diffusion/herald/DiffusionCommitCommitterProjectsHeraldField.php (8 lines)
Psrc/applications/diffusion/herald/DiffusionPreCommitContentAuthorPackagesHeraldField.php (21 lines)
Copied from src/applications/diffusion/herald/DiffusionPreCommitContentCommitterProjectsHeraldField.php
Msrc/applications/diffusion/herald/DiffusionPreCommitContentAuthorProjectsHeraldField.php (9 lines)
Psrc/applications/diffusion/herald/DiffusionPreCommitContentCommitterPackagesHeraldField.php (21 lines)
Copied from src/applications/diffusion/herald/DiffusionPreCommitContentCommitterProjectsHeraldField.php
Psrc/applications/diffusion/herald/DiffusionPreCommitContentCommitterProjectsHeraldField.php (9 lines)
Copied to multiple locations:
src/applications/diffusion/herald/DiffusionPreCommitContentAuthorPackagesHeraldField.php
src/applications/diffusion/herald/DiffusionPreCommitContentCommitterPackagesHeraldField.php

Diff 49931

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitAuthorPackagesHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitAuthorProjectsHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitCommitterPackagesHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionCommitCommitterProjectsHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentAuthorPackagesHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentAuthorProjectsHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentCommitterPackagesHeraldField.php

Loading...
View Options

src/applications/diffusion/herald/DiffusionPreCommitContentCommitterProjectsHeraldField.php

Loading...
Phabricator · Built by Phacility