Page MenuHomePhabricator

Fix "display" index issue when editing Paths in Owners
Closed, ResolvedPublic

Description

See PHI1560. Example reproduction instructions:

  • Edit an Owners package.
  • Add a new path.

This produces:

[Thu Nov 21 11:17:08.813934 2019] [php7:notice] [pid 19857] [client 127.0.0.1:53359] [2019-11-21 11:17:08] ERROR 8: Undefined index: display at [/Users/epriestley/dev/core/lib/phabricator/src/applications/owners/storage/PhabricatorOwnersPath.php:98]
[Thu Nov 21 11:17:08.814582 2019] [php7:notice] [pid 19857] [client 127.0.0.1:53359] arcanist(head=experimental, ref.master=cc850163f30c, ref.experimental=e19fe12f7ecd), corgi(head=master, ref.master=72dc914db4d4), instances(head=master, ref.master=b5c5d33c3f67), libcore(), phabricator(head=master, ref.master=374f8b10b3cf, custom=9), phutil(head=master, ref.master=39ed96cd818a), services(head=master, ref.master=c4bd119b358e)
[Thu Nov 21 11:17:08.814601 2019] [php7:notice] [pid 19857] [client 127.0.0.1:53359]   #0 PhabricatorOwnersPath::getScalarKeyForRef(array) called at [<phabricator>/src/applications/owners/storage/PhabricatorOwnersPath.php:82]
[Thu Nov 21 11:17:08.814641 2019] [php7:notice] [pid 19857] [client 127.0.0.1:53359]   #1 PhabricatorOwnersPath::getSetFromTransactionValue(array) called at [<phabricator>/src/applications/owners/storage/PhabricatorOwnersPath.php:68]
[Thu Nov 21 11:17:08.814660 2019] [php7:notice] [pid 19857] [client 127.0.0.1:53359]   #2 PhabricatorOwnersPath::getTransactionValueDiff(array, array) called at [<phabricator>/src/applications/owners/storage/PhabricatorOwnersPath.php:62]
[Thu Nov 21 11:17:08.814708 2019] [php7:notice] [pid 19857] [client 127.0.0.1:53359]   #3 PhabricatorOwnersPath::getTransactionValueChanges(array, array) called at [<phabricator>/src/applications/owners/xaction/PhabricatorOwnersPackagePathsTransaction.php:91]
[Thu Nov 21 11:17:08.814727 2019] [php7:notice] [pid 19857] [client 127.0.0.1:53359]   #4 PhabricatorOwnersPackagePathsTransaction::validateTransactions(PhabricatorOwnersPackage, array) called at [<phabricator>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:2601]
[Thu Nov 21 11:17:08.814734 2019] [php7:notice] [pid 19857] [client 127.0.0.1:53359]   #5 PhabricatorApplicationTransactionEditor::validateTransaction(PhabricatorOwnersPackage, string, array) called at [<phabricator>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1047]
[Thu Nov 21 11:17:08.814741 2019] [php7:notice] [pid 19857] [client 127.0.0.1:53359]   #6 PhabricatorApplicationTransactionEditor::applyTransactions(PhabricatorOwnersPackage, array) called at [<phabricator>/src/applications/owners/controller/PhabricatorOwnersPathsController.php:64]
[Thu Nov 21 11:17:08.814747 2019] [php7:notice] [pid 19857] [client 127.0.0.1:53359]   #7 PhabricatorOwnersPathsController::handleRequest(AphrontRequest) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:286]
[Thu Nov 21 11:17:08.814755 2019] [php7:notice] [pid 19857] [client 127.0.0.1:53359]   #8 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:206]
[Thu Nov 21 11:17:08.814762 2019] [php7:notice] [pid 19857] [client 127.0.0.1:53359]   #9 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:35]