Page MenuHomePhabricator

Remove legacy pre-loading of handles from Herald rendering
ClosedPublic

Authored by epriestley on Jan 23 2020, 7:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 4:01 AM
Unknown Object (File)
Feb 23 2024, 4:47 AM
Unknown Object (File)
Feb 12 2024, 8:35 AM
Unknown Object (File)
Feb 3 2024, 11:32 PM
Unknown Object (File)
Jan 15 2024, 5:16 PM
Unknown Object (File)
Dec 26 2023, 8:46 PM
Unknown Object (File)
Dec 24 2023, 9:59 AM
Unknown Object (File)
Dec 23 2023, 4:22 PM
Subscribers
None

Details

Summary

Ref T13480. When Herald renders rules, it partly uses a very old handle pre-loading mechanism where PHIDs are extracted and loaded upfront. This was obsoleted a long time ago and was pretty shaky even when it worked. Get rid of it to simplify the code a little.

Test Plan

Viewed Herald rules rendered into static text with PHID list actions, saw handles. Grepped for all affected methods.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jan 29 2020, 11:07 PM
This revision was automatically updated to reflect the committed changes.