Page MenuHomePhabricator

Remove legacy pre-loading of handles from Herald rendering

Authored by epriestley on Jan 23 2020, 7:42 PM.



Ref T13480. When Herald renders rules, it partly uses a very old handle pre-loading mechanism where PHIDs are extracted and loaded upfront. This was obsoleted a long time ago and was pretty shaky even when it worked. Get rid of it to simplify the code a little.

Test Plan

Viewed Herald rules rendered into static text with PHID list actions, saw handles. Grepped for all affected methods.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 23 2020, 7:42 PM
epriestley requested review of this revision.Jan 23 2020, 7:43 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 29 2020, 11:07 PM
This revision was automatically updated to reflect the committed changes.