Page MenuHomePhabricator

In Herald "Commit" rules, use repository identities to identify authors and committers

Authored by epriestley on Jan 29 2020, 6:40 PM.



Ref T13480. The Herald "Commit" rules still use raw commit data properties to identify authors and committers. Instead, use repository identities.

Test Plan

Wrote a Herald rule using all four fields, ran it against various commits with and without known authors. Checked transcript for sensible field values.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 29 2020, 6:40 PM
epriestley requested review of this revision.Jan 29 2020, 6:41 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 29 2020, 11:49 PM
This revision was automatically updated to reflect the committed changes.