Page MenuHomePhabricator
Differential D19185

Use "pathIndex" in some owners package queries to improve query plans
ClosedPublic
Actions

Authored by epriestley on Mar 7 2018, 4:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 5:37 AM
Unknown Object (File)
Sun, Feb 9, 5:37 AM
Unknown Object (File)
Sun, Feb 9, 5:37 AM
Unknown Object (File)
Sun, Feb 9, 1:10 AM
Unknown Object (File)
Thu, Jan 30, 4:05 PM
Unknown Object (File)
Thu, Jan 30, 5:25 AM
Unknown Object (File)
Thu, Jan 30, 5:24 AM
Unknown Object (File)
Thu, Jan 30, 5:24 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T11015: Owners has perplexing behavior when directory paths are not terminated with a slash
Commits
rP516aaad3410c: Use "pathIndex" in some owners package queries to improve query plans
Summary

Depends on D19184. Ref T11015. Now that we have a digest index column, we can improve some of the queries a bit.

Test Plan
  • Ran queries from revision pages before and after with and without EXPLAIN.
  • Saw the same results with much better EXPLAIN plans.
  • Fragment size is now fixed at 12 bytes per fragment, so we can shove more of them in a single query.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
owners/
query/
20 lines
storage/
11 lines
3 lines

Diff 45952

View Options

src/applications/owners/query/PhabricatorOwnersPackageQuery.php

Loading...
View Options

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...
View Options

src/applications/owners/storage/PhabricatorOwnersPath.php

Loading...
Phabricator · Built by Phacility