Page MenuHomePhabricator

Treat Owners paths like "/src/backend" and "/src/backend/" identically
ClosedPublic

Authored by epriestley on Mar 7 2018, 4:14 AM.
Tags
None
Referenced Files
F18741597: D19184.id.diff
Thu, Oct 2, 2:45 PM
F18739807: D19184.diff
Wed, Oct 1, 11:01 PM
F18733755: D19184.id.diff
Tue, Sep 30, 10:41 PM
F18672398: D19184.diff
Thu, Sep 25, 7:27 AM
F18640959: D19184.diff
Sep 18 2025, 7:21 PM
F18640939: D19184.diff
Sep 18 2025, 7:15 PM
F18600545: D19184.diff
Sep 13 2025, 10:00 AM
F18509401: D19184.id.diff
Sep 5 2025, 3:23 AM
Subscribers
None

Details

Summary

Depends on D19183. Ref T11015. Currently, adding a trailing slash works great and omitting it mysteriously doesn't work.

Store a normalized version with an unconditional trailing slash for the lookup logic to operate on, and a separate display version which tracks what the user actually typed.

Test Plan
  • Entered "/src/main.c", "/src/main.c/", saw them de-duplicate.
  • Entered "/src/main.c", saw it stay that way in the UI but appear as "/src/main.c/" internally.
  • Added a rule for "/src/applications/owners" (no slash), created a revision touching paths in that directory, saw Owners fire for it.
  • Changed the display value of a path only ("/src/main.c" to "/src/main.c/"), saw the update reflected in the UI without any beahvioral change.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 4:31 AM
This revision was automatically updated to reflect the committed changes.