Page MenuHomePhabricator

Treat Owners paths like "/src/backend" and "/src/backend/" identically

Authored by epriestley on Mar 7 2018, 4:14 AM.



Depends on D19183. Ref T11015. Currently, adding a trailing slash works great and omitting it mysteriously doesn't work.

Store a normalized version with an unconditional trailing slash for the lookup logic to operate on, and a separate display version which tracks what the user actually typed.

Test Plan
  • Entered "/src/main.c", "/src/main.c/", saw them de-duplicate.
  • Entered "/src/main.c", saw it stay that way in the UI but appear as "/src/main.c/" internally.
  • Added a rule for "/src/applications/owners" (no slash), created a revision touching paths in that directory, saw Owners fire for it.
  • Changed the display value of a path only ("/src/main.c" to "/src/main.c/"), saw the update reflected in the UI without any beahvioral change.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 7 2018, 4:14 AM
epriestley requested review of this revision.Mar 7 2018, 4:16 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 4:31 AM
This revision was automatically updated to reflect the committed changes.