In T12804#226305, @epriestley wrote:

In T12804#226290, @sascha-egerer wrote:

T8442 would help a lot for those "I have to many repositories"

Today, you could save searches in different Spaces. For example, here I've done this:

• Search for "Spaces: Phacility".
• Save the search as "Phacility Repositories".

Do you use this strategy today? How would T8442 improve on this? If you don't do this already, but dividing repositories by Space is useful, why don't you currently do it? Put another way, what problem exists with search today that T8442 solves but search changes could not solve?

T8442 would help a lot for those "I have to many repositories"

I have that problem again. There is no relation between the file and the Diff. Don't know how that can happen...

I hate commanding arc with these commands. Can we also please add please do a prefix for everything? Like arc please do a diff, arc please do a land

Ok sorry for that - that was a really bad example... The problem is that only complete words are found and not parts of it.
So you'll get a result for "Hello" but not for "Hell".
So searching for "Component" will give no result if the title is "Components". Is that correct?

@CodeMouse92 yes the project has a subproject. But changing the policies as described above works around that issue.

Thanks! Maybe this can save some time for some people...

Great!

I already thought that while writing the ticket ;-) That's the reason i added the last sentence to adjust the documentation. Maybe it would be good to know that this feature is using the git mirror function and may overwrite data of the mirror.

In T10731#168665, @epriestley wrote:

The use of sh as it is written in the documentation is important.

This is what you are intended to write:

$ sh -c 'echo "$0"' xxx
xxx

This is what it looks like you're writing:

$ echo $0 xxx
-bash xxx

I've also added myself as a subscriber (even if i was auto subscribed because i'm the reviewer) but that doesn't change anything. Still no permissions.
The problem can also be reproduced when clicking on Download Raw Diff in the interface.

In T10725#168658, @chad wrote:

Files attached to other objects take on permissions of the object itself. So if you add a file to a restricted task, the restriction is also applied to the file.

In T10725#168645, @chad wrote:

My question was what is the relation to User B and the Diff. Is User B a reviewer, a subscriber, or ... ?

In T10725#168508, @chad wrote:

What's the relationship between user b and the patch, specifically?

Ok i found the reason for the problem.
If you set Applications → Projects → Edit Policies → Default View Policy to Project Memebers i does not work. You can still create normal projects and subprojects but you can't create milestones. I think that is because milestones do not have members but the permissions are evaluated against the "project members".

Ok, then I'll investigate further and give feedback as soon as i've found something

Yes I'm member of all those groups as described above. I'm also an "Admin"

I've posted a screenshot of my settings or do you need anything else?

Yeah i did basically the same. What are the permissions of your project?

I would vote for X-Forwarded-Proto support in AphrontRequest::isHTTPS

@jhurwitz I use conduit to fetch wiki pages and format them with conduit to get a html syntax. I do that to add Wiki-Pages to a Frontend-Styleguide. Then i just add the required phabricator css and everything looks fine.
So i think you can write your own simple script to do everything over conduit, right?

Really good commit message! Thank you for that! Learned a lot again with your help...

Any progress here? What about setting the hierachy limit in the wiki document itself? So you can say "show X levels in the document hierachy of this page" where X is inherited and has a default value of 2?

In T9123#138576, @epriestley wrote:

We're kinda-sort doing builds for commits now:

Fixed in rARC3e36b3fc430d

This patch has broken the ArcanistPhpunitTestResultParser.php as phutil_json_decode returns an array and not an object as json_decode has before. I'll push an patch for this

Create a bot User that has Access to a Repository but not to Diffusion. Try to clone which will fail.

What about a configuration option runUnitTestsOnLanding that could be disabled, allTests, changedFiles?
I don't see a benefit for running linters again as the comnination of 2 patches should not change any code style, right?

That does also fix the problem that unit tests are not executed when doing an arc diff if they are not stored directly in the tests folder.

Any comments on that?

As far as i can see this can't work but is a bug in PHPCS. https://github.com/squizlabs/PHP_CodeSniffer/blob/master/CodeSniffer/CLI.php#L875
But i really don't understand why it works on your machine...

oh ok... i can reproduce that on 2 machines. What's your OS? What's your php version?
I'm on MacOS 10.9.5

And you have this still applied?

public function supportsReadDataFromStdin() {
  return true;
}

A the same problem for logout. So you can't logout currently on iOS by using the standard interface.

Now the linter does also fail when you have an empty php file. Instead of showing the correct message

arc lint foo.php
>>> Lint for foo.php:

Removed some whitespace changes

In T5064#59055, @BYK wrote:

Can't we run arc unit and arc lint right before pushing and if they fail clean up by doing git reset --hard HEAD^1 and switching to the branch? Obviously I'm only thinking about the git case here where arc needs to handle hg and svn too but I'd like to hear more about this since I've landed code which actually broke unit tests in the past during a merge or rebase. It was not fun :)

Should i create a Task for "Dashboard with 4 columns"?
What about making the column amount flexible?

Ups... Looks like I've Looked at a wrong task... There is no difference to T4139. Sorry...

These tasks are both not related to native browser notifications but to realtime Chat Updates. So i thought i create a new ticket. But if this will also Done in this tickets i'm Fine with that.

Demo comment to try to reproduce the issue

As already said in IRC I'll implement this function with a custom script and abondon this revision.

I've just run the unit test cases against +, array_merge, array_merge_recursive and array_merge_recursive_overrule to show the different result. P1142
Do you have a better idea how to handle these configurations?

In D9135#6, @epriestley wrote:

This is e.g. usefull to merge a global configuration file with a stage specific configuration.

Where do you want to use this specifically?

I worry this won't be sufficient in the general case. If both configuration files have lists, sometimes those lists should be combined instead of overwritten, and other times they should be overwritten entirely.

Another approach might be to adjust the umask when we write stuff to the local disk engine.