Page MenuHomePhabricator

Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential
Closed, ResolvedPublic

Assigned To
Authored By
epriestley
Mar 19 2016, 2:28 AM
Tags
Tokens
"Doubloon" token, awarded by avivey."Piece of Eight" token, awarded by chad.

Description

The "Local Commits" and "Open Revisions Affecting These Files" boxes on revisions aren't especially useful in many cases, and we want to try putting them into tabs with the new design.

This is slightly involved technically because the API for adding tabs is PHUIObjectBoxView->addPropertyList(), which only accepts PHUIPropertyListView objects, and none of these views are property lists. That needs to be generalized a bit first.

Event Timeline

I spent some time on this, but this ends up being more involved than I thought because there's a lot of weirdness around how actions and property lists interact, so this is probably blocked on making all UIs which use property list tabs and actions switch to the two column view.

I think this list isn't actually that long -- the only one I was able to find immediately was Files. So the pathway forward is something like:

  • Convert Files to two-column.
  • Convert anything else I missed to two-column.
  • Remove the tab / action list / property list interaction code (can we this whole interaction? Not sure how much work is involved...)
  • Convert tabs to a new API so addPropertyList() is no longer the API for tabs (I have ~half a diff for this).
  • Swap API implementations to support arbitrary tab content (I have ~half a diff for this).

FWIW, I've pretty much never looked at "Open Revisions Affecting These Files", and only look at "Local Commits" to check if the parent commit is already pushed.

Yeah, pretty much the same for me. I believe "Open Revisions" has a small population of fans and "Local Commits" may get more useful eventually (e.g., after whatever happens with T1508) but I think we're on fairly firm ground shoving these into tabs.

FWIW, I've pretty much never looked at "Open Revisions Affecting These Files", and only look at "Local Commits" to check if the parent commit is already pushed.

I never look at local commits (they are specific to the user) and sometimes look at "Open Revisions" to make sure I'm not going to stampede on anyone else. This is likely related to organization size.

~ My 2c

eadler added a project: Restricted Project.Jul 7 2016, 5:20 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
eadler removed a subscriber: eadler.

Some additional work (the "Stack" tab) ended up overlapping with T4788 but I think this is resolved.