Paths

Table of Contentst

Diffusion Arcanist 3ffed59bd7fb

Update xhpast linter rules for new function AST format
3ffed59bd7fb
Actions

Tags

None

Referenced Files

None

Subscribers

Description

Update xhpast linter rules for new function AST format

Summary: See D15678. A node containing a return type hint is added right before the statement body node. This updates all relevant linter rules to now retrieve the body from the correct index.

Test Plan: Ran arc unit --everything, inspected every single message to make sure all xhpast test cases succeeded. Also grepped for getChildByIndex(5 and getChildOfType(5.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15814

Details

Provenance

richardvanvelzen	Authored on Apr 28 2016, 2:59 PM
richardvanvelzen	Pushed on Apr 29 2016, 12:38 PM

Reviewer

Blessed Reviewers

Differential Revision

D15814: Update xhpast linter rules for new function AST format

Parents

rARCea6fc7789295: Fix incorrect variable for linter standards

Branches

Unknown

Tags

Unknown

Build Status

Buildable 11979
Build 15067: Run Core Tests

Event Timeline

richardvanvelzen committed rARC3ffed59bd7fb: Update xhpast linter rules for new function AST format (authored by richardvanvelzen).Apr 29 2016, 12:38 PM

Harbormaster failed to build B11979: rARC3ffed59bd7fb: Update xhpast linter rules for new function AST format!Apr 29 2016, 12:38 PM

Harbormaster failed to build B11979: rARC3ffed59bd7fb: Update xhpast linter rules for new function AST format!Apr 29 2016, 12:44 PM

That test failure looks possibly-legitimate, let me take a closer look...

Was xhpast rebuilt properly? I can't seem to reproduce that failure locally.

It should rebuild it every time, and I think it reproduces locally for me.

epriestley mentioned this in D15819: When running XHPAST unit tests, include the "syntax error" lint rule.Apr 29 2016, 1:02 PM

epriestley mentioned this in D15820: Regnerate XHPAST with Bison 3.0.4.Apr 29 2016, 1:29 PM

epriestley mentioned this in rARC768e1a56bc5f: When running XHPAST unit tests, include the "syntax error" lint rule.Apr 29 2016, 1:30 PM

epriestley mentioned this in rPHUf27bc7f9ca83: Regnerate XHPAST with Bison 3.0.4.Apr 29 2016, 1:54 PM

Harbormaster completed building B11979: rARC3ffed59bd7fb: Update xhpast linter rules for new function AST format.Apr 29 2016, 4:18 PM

Changes (8)

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistAbstractMethodBodyXHPASTLinterRule.php

ArcanistInterfaceMethodBodyXHPASTLinterRule.php

ArcanistReusedAsIteratorXHPASTLinterRule.php

ArcanistReusedIteratorReferenceXHPASTLinterRule.php

ArcanistStaticThisXHPASTLinterRule.php

ArcanistToStringExceptionXHPASTLinterRule.php

ArcanistUndeclaredVariableXHPASTLinterRule.php

ArcanistUselessOverridingMethodXHPASTLinterRule.php

rARC3ffed59bd7fb

src/lint/linter/xhpast/rules/ArcanistAbstractMethodBodyXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistInterfaceMethodBodyXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistReusedAsIteratorXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistReusedIteratorReferenceXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistStaticThisXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistToStringExceptionXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistUndeclaredVariableXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistUselessOverridingMethodXHPASTLinterRule.php

Loading...