Diffusion libphutil 5f573d2b7f27

Correctly support try..catch..finally in xhpast
5f573d2b7f27
Actions

Description

Correctly support try..catch..finally in xhpast

Summary: Ref T4334. The catch clauses are optional when a finally is available.

Test Plan: run xhpast with some files. Also added unit tests

Reviewers: joshuaspence, epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: joshuaspence, epriestley, Korvin

Maniphest Tasks: T4334

Differential Revision: https://secure.phabricator.com/D10337

Details

Provenance

richardvanvelzen	Authored on Mar 17 2016, 11:50 AM
richardvanvelzen	Pushed on Mar 17 2016, 1:36 PM

Reviewer

Blessed Reviewers

Differential Revision

D10337: Correctly support try..catch..finally in xhpast

Parents

rPHUd20d6e725037: Fix an issue with highlighting PHP snippets with leading whitespace using XHPAST

Branches

Unknown

Tags

Unknown

Tasks

T4334: Support PHP5.4+ syntax in XHPAST

Build Status

Buildable 11188
Build 13881: Run Core Tests

Event Timeline

richardvanvelzen committed rPHU5f573d2b7f27: Correctly support try..catch..finally in xhpast (authored by richardvanvelzen).Mar 17 2016, 1:36 PM

richardvanvelzen added a task: T4334: Support PHP5.4+ syntax in XHPAST.

Harbormaster completed building B11188: rPHU5f573d2b7f27: Correctly support try..catch..finally in xhpast.Mar 17 2016, 1:36 PM

Changes (6)

Path

Size

src/

parser/

xhpast/

__tests__/

data/

	php-only-finally.test
	php-empty-heredoc.php.test

	php-try-no-catch-or-finally.test
	base-fail-syntax.php.test

bin/

PhutilXHPASTBinary.php

support/

xhpast/

parser.y

parser.yacc.cpp

xhpast.cpp

rPHU5f573d2b7f27

View Options

src/parser/xhpast/tests/data/php-only-finally.test

View Options

src/parser/xhpast/tests/data/php-try-no-catch-or-finally.test

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

View Options

support/xhpast/parser.y

View Options

support/xhpast/parser.yacc.cpp

View Options

Correctly support try..catch..finally in xhpast5f573d2b7f27Actions

Description

Details

Event Timeline

Changes (6)

rPHU5f573d2b7f27

src/parser/xhpast/__tests__/data/php-only-finally.test

src/parser/xhpast/__tests__/data/php-try-no-catch-or-finally.test

src/parser/xhpast/bin/PhutilXHPASTBinary.php

support/xhpast/parser.y

support/xhpast/parser.yacc.cpp

support/xhpast/xhpast.cpp

Correctly support try..catch..finally in xhpast
5f573d2b7f27
Actions

src/parser/xhpast/tests/data/php-only-finally.test

src/parser/xhpast/tests/data/php-try-no-catch-or-finally.test