HomePhabricator

Correctly detect new version of xhpast build

Description

Correctly detect new version of xhpast build

Summary: When running lint after xhpast is updated, it tests whether the version is up-to-date. Because the version isn't reset before the test, it would think that the build failed, requiring a second run of lint

Test Plan: Downgraded xhpast, ran lint. Saw broken xhpast, but correct xhpast on second run. Applied patch, and got correct lint results regardless of version.

Reviewers: epriestley, Blessed Reviewers, chad

Reviewed By: epriestley, Blessed Reviewers, chad

Subscribers: Korvin, Firehed

Differential Revision: https://secure.phabricator.com/D15945

Details

Provenance
richardvanvelzenAuthored on May 19 2016, 10:49 AM
richardvanvelzenPushed on May 19 2016, 2:08 PM
Reviewer
Blessed Reviewers
Differential Revision
D15945: Correctly detect new version of xhpast build
Parents
rPHU4b75e0c34e52: Add coalesce and spaceship operators to xhpast
Branches
Unknown
Tags
Unknown
Build Status
Buildable 12268
Build 15502: Run Core Tests